You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/05/01 05:06:23 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2656: ARTEMIS-2328 Routing after empty addresses could lead to invalid mess…

michaelandrepearce commented on a change in pull request #2656: ARTEMIS-2328 Routing after empty addresses could lead to invalid mess…
URL: https://github.com/apache/activemq-artemis/pull/2656#discussion_r280006284
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##########
 @@ -907,8 +907,7 @@ public RoutingStatus route(final Message message,
       AddressInfo addressInfo = addressManager.getAddressInfo(address);
 
       if (bindingMove != null) {
-         context.clear();
-         context.setReusable(false);
+         context.clear().setReusable(false);
 
 Review comment:
   really is that needed? having on two lines helps when running debuggers

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services