You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Marco Risaliti (JIRA)" <ji...@apache.org> on 2007/05/22 18:08:16 UTC
[jira] Created: (OFBIZ-1009) Reorganization of PayPalEvents
Reorganization of PayPalEvents
------------------------------
Key: OFBIZ-1009
URL: https://issues.apache.org/jira/browse/OFBIZ-1009
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk, Release Branch 4.0
Environment: mac os x
Reporter: Marco Risaliti
Priority: Minor
Fix For: SVN trunk, Release Branch 4.0
I have reorganizated the PayPalEvents.java performing those tasks:
- removing unused variable to avoid compile warning
- removed hardcoded error messages to use uiLabels.properties
- correct the bug that does not create the payment for the order that was paid on PayPal
- removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
This patch can be tested also on the front-end application on http://www.ofbiz.it
After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
Thanks in advance
Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534813 ]
Jacques Le Roux commented on OFBIZ-1009:
----------------------------------------
Marco,
Yes of course, 2 patches would be better
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551775 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Jacques and all committers,
May I can commit the PayPal_bug2.patch into the release 4 ?
I have not the possibility to test it because yesterday when I test on my laptop it was not possible the notify from PayPal with a fixed IP site.
So to test it I need to use it the www.ofbiz.it site.
I think it is a bug fix and it can be included into the release 4.
Thanks
Marco
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534768 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Hi Jacques,
if you have the time also to review this patch it will be great.
Thanks in advance
Marco
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535731 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Jacques,
remember to close the issue OFBIZ-175 and OFBIZ-247 if this issue will be closed because they are duplicate of the same issue.
Marco
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_i18n.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Attachment: PayPal_bug2.patch
This is the new patch I have tested I will commit now in the trunk, I will leave this issue open because probably it has to be merged into the release 4 by at the moment I did not how to do it.
Thanks
Marco
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Attachment: PayPal.patch
I have not verified but I think that this bug is also in the release 4.0.
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Attachment: (was: PayPal_i18n.patch)
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti closed OFBIZ-1009.
---------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 4.0
I have committed in rev. 604311 into release 4 and so I now close this issue.
Thanks
Marco
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551650 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
I have applied those patch also on www.ofbiz.it and I have configured PayPal and it can be tested on this server using simply a sandbox paypal buyer user.
Thanks
Marco
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "mrisaliti@libero.it" <mr...@libero.it>.
Yes, mainly this patch is an improvement but the bug is if you use
PayPal then during the notification the payment/payment gateway
response and order payment preference will be not be created.
So if you consider this is not a bug you can apply it on to main trunk.
Thanks a lot
Marco
Il giorno 22/mag/07, alle ore 18:12, David E. Jones (JIRA) ha scritto:
>
> [ https://issues.apache.org/jira/browse/OFBIZ-1009?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12497914 ]
>
> David E. Jones commented on OFBIZ-1009:
> ---------------------------------------
>
> Just a quick thought: these appear to be new features and
> improvements of the PayPal stuff rather than a bug fix, and
> probably shouldn't be included in the release branch.
>
>> Reorganization of PayPalEvents
>> ------------------------------
>>
>> Key: OFBIZ-1009
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>> Project: OFBiz (The Open for Business Project)
>> Issue Type: Bug
>> Components: accounting
>> Affects Versions: SVN trunk, Release Branch 4.0
>> Environment: mac os x
>> Reporter: Marco Risaliti
>> Priority: Minor
>> Fix For: SVN trunk, Release Branch 4.0
>>
>>
>> I have reorganizated the PayPalEvents.java performing those tasks:
>> - removing unused variable to avoid compile warning
>> - removed hardcoded error messages to use uiLabels.properties
>> - correct the bug that does not create the payment for the order
>> that was paid on PayPal
>> - removed an hard-coded link to production PayPal (http://
>> www.paypal.com/cgi-bin/webscr) and retrieved from the
>> payment.properties
>> This patch can be tested also on the front-end application on
>> http://www.ofbiz.it
>> After review and commit this patch the issue OFBIZ-175 and
>> OFBIZ-247 can be closed.
>> Thanks in advance
>> Marco Risaliti
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497914 ]
David E. Jones commented on OFBIZ-1009:
---------------------------------------
Just a quick thought: these appear to be new features and improvements of the PayPal stuff rather than a bug fix, and probably shouldn't be included in the release branch.
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Attachment: PayPal_bug.patch
Hi Jacques,
this is the patch that correct the bug in order payment preference creation and I have removed an hardcoded link to paypal production.
I think that this issue is currenctly present in release 4.0 but I have not tested in it.
I'm sure that with this patch the issue is solved in the trunk.
This are the steps to test the paypal:
- configure correctly the payment.properties to go to the paypal sandbox (https://www.sandbox.paypal.com/us/cgi-bin/webscr) and configure the return url to your public ip address of the current ofbiz running application.
- connect to paypal sandbox environment before open OFBiz and connect to PayPal Developer Central with your paypal buyer user
- checkout an order with paypal payment on the ecommerce application.
- ofbiz will redirect to paypal
- login to paypal with paypal buyer user
- press pay now and then return to merchant
Thanks
Marco
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534779 ]
Jacques Le Roux commented on OFBIZ-1009:
----------------------------------------
Hi Marco,
Yes I will soon. What David meant is that you have also changed some stuff not bug related. The best would have been to create a patch for bugs fixes and another one for other stuffes. Anyway, I will see if this really need to be in release when reviewing.
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523617 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Can someone review and commit this patch in the trunk ?
Thanks in advance
Marco
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Summary: PayPalEvents does not create order payment preference (was: Reorganization of PayPalEvents)
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_i18n.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Attachment: PayPal_i18n.patch
Hi Jacques,
this is the patch for i18n improvement of PayPalEvents.java.
This patch can be applied to trunk only and not to the release 4 because it's not a bug fix.
Thanks
Marco
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_i18n.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551610 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Fixed in rev. 604030 in the trunk and it has still to be fixed in release 4.
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552214 ]
Jacques Le Roux commented on OFBIZ-1009:
----------------------------------------
Marco,
Sorry I did no answer to your demands above. If you need some help tp revert from release to reapply without links to HWM server feel free to ask.
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535739 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Jacques,
I have move the improvements on PayPalEvents into the new issue OFBIZ-1351.
Marco
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534802 ]
Marco Risaliti commented on OFBIZ-1009:
---------------------------------------
Hi Jacques,
if you want I can provide two different patches to solve the bug also into the release 4.0.
By the way I have seen that I have provide a wrong patch with no relative path to the ofbiz directory and so I will upload a new patch to solve this problem.
Thanks a lot
Marco
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1009:
----------------------------------
Attachment: (was: PayPal.patch)
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "BJ Freeman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548894 ]
BJ Freeman commented on OFBIZ-1009:
-----------------------------------
not sure if this is an oversite
+#payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
should be
+#payment.paypal.confirm=https://www.paypal.com/cgi-bin/webscr
https://www.paypal.com/IntegrationCenter/ic_ipn.html
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1009) PayPalEvents does not create order
payment preference
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti reassigned OFBIZ-1009:
-------------------------------------
Assignee: Marco Risaliti
> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato updated OFBIZ-1009:
-------------------------------------
Fix Version/s: (was: Release Branch 4.0)
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.