You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/11 16:38:44 UTC

[GitHub] [pulsar-dotpulsar] dionjansen opened a new issue #65: Support for Seek in IReader interface

dionjansen opened a new issue #65:
URL: https://github.com/apache/pulsar-dotpulsar/issues/65


   Both `IConsumer` and `IReader` should expose a `Seek` method to reset the cursor of an existing reader channel (see [java docs](http://pulsar.apache.org/api/client/2.6.0-SNAPSHOT/org/apache/pulsar/client/api/Reader)).
   
   I believe this is a matter of:
   
   1. Adding a `Task<CommandSuccess> Send(CommandSeek command, CancellationToken cancellationToken)` to `IReaderChannel` (I believe the `ReaderChannelFactory` actually returns a `ConsumerChannel` instance on create so this should be implemented already)
   1. Adding and implementing the `ValueTask Seek(MessageId messageId, CancellationToken cancellationToken)` for `IReader`
   
   @blankensteiner I can submit a PR for this if you agree with the suggested implementation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #65: Support for Seek in IReader interface

Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #65:
URL: https://github.com/apache/pulsar-dotpulsar/issues/65#issuecomment-743340240


   Hi @dionjansen 
   Sure, go ahead! Maybe we should also add seeking on the publish-time?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] blankensteiner closed issue #65: Support for Seek in IReader interface

Posted by GitBox <gi...@apache.org>.
blankensteiner closed issue #65:
URL: https://github.com/apache/pulsar-dotpulsar/issues/65


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] dionjansen commented on issue #65: Support for Seek in IReader interface

Posted by GitBox <gi...@apache.org>.
dionjansen commented on issue #65:
URL: https://github.com/apache/pulsar-dotpulsar/issues/65#issuecomment-748493320


   @blankensteiner that was fast thanks a bunch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #65: Support for Seek in IReader interface

Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #65:
URL: https://github.com/apache/pulsar-dotpulsar/issues/65#issuecomment-746246230


   This is supported in 0.10.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #65: Support for Seek in IReader interface

Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #65:
URL: https://github.com/apache/pulsar-dotpulsar/issues/65#issuecomment-743918777


   Hi @dionjansen 
   I had some time and have pushed the feature. Maybe you could have a look and help test it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org