You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2009/01/21 21:26:01 UTC
DO NOT REPLY [Bug 46578] New: Flawed header
https://issues.apache.org/bugzilla/show_bug.cgi?id=46578
Summary: Flawed header
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Core
AssignedTo: bugs@httpd.apache.org
ReportedBy: edwin@cheatah.nl
The header file ap_config_auto.h is a bit flawed. It defines PACKAGE_NAME and
PACKAGE_VERSION, and similar constants. If one would like to compile their own
module, one could write something like:
#ifdef HAVE_CONFIG_H
#include <config.h>
#endif
#include <httpd.h>
#include <http_config.h>
#include <http_protocol.h>
#include <ap_config.h>
This would give compiler warnings (not errors) about PACKAGE_NAME being
re-defined. This is a bit sloppy and certainly not necessary. Hardly any C
program defines PACKAGE_NAME and similar constants outside config.h, and header
files should certainly not re-define them.
It would be better to have this in ap_config_auto.h:
#ifndef PACKAGE_BUGREPORT
# define PACKAGE_BUGREPORT ""
#endif
So it's not very critical, but it's also not nice to cause warnings that need
not be caused.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 46578] Flawed header
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46578
Jeff Trawick <tr...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Windows XP |All
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org