You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/17 22:27:31 UTC
Review Request 67951: Added optional `path_separator` parameter to
`Path` constructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/
-----------------------------------------------------------
Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
Bugs: MESOS-5904 and MESOS-8564
https://issues.apache.org/jira/browse/MESOS-5904
https://issues.apache.org/jira/browse/MESOS-8564
Repository: mesos
Description
-------
This defaults to `os::PATH_SEPARATOR` and so by default retains the
previous behavior. However, now `Path` can be arbitrarily used with,
e.g., URLs on Windows by providing `/` as the separator.
Diffs
-----
3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d
Diff: https://reviews.apache.org/r/67951/diff/1/
Testing
-------
`stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67951: Added optional `path_separator` parameter to
`Path` constructor.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/#review206352
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On July 19, 2018, 8:41 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67951/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 8:41 p.m.)
>
>
> Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
>
>
> Bugs: MESOS-5817 and MESOS-5904
> https://issues.apache.org/jira/browse/MESOS-5817
> https://issues.apache.org/jira/browse/MESOS-5904
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This defaults to `os::PATH_SEPARATOR` and so by default retains the
> previous behavior. However, now `Path` can be arbitrarily used with,
> e.g., URLs on Windows by providing `/` as the separator.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d
>
>
> Diff: https://reviews.apache.org/r/67951/diff/3/
>
>
> Testing
> -------
>
> `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67951: Added optional `path_separator` parameter to
`Path` constructor.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/
-----------------------------------------------------------
(Updated July 19, 2018, 1:41 p.m.)
Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
Changes
-------
Removed const member so that it can be default copy constructed.
Bugs: MESOS-5817 and MESOS-5904
https://issues.apache.org/jira/browse/MESOS-5817
https://issues.apache.org/jira/browse/MESOS-5904
Repository: mesos
Description
-------
This defaults to `os::PATH_SEPARATOR` and so by default retains the
previous behavior. However, now `Path` can be arbitrarily used with,
e.g., URLs on Windows by providing `/` as the separator.
Diffs (updated)
-----
3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d
Diff: https://reviews.apache.org/r/67951/diff/3/
Changes: https://reviews.apache.org/r/67951/diff/2-3/
Testing
-------
`stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67951: Added optional `path_separator` parameter to
`Path` constructor.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/#review206179
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On July 17, 2018, 10:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67951/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 10:27 p.m.)
>
>
> Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
>
>
> Bugs: MESOS-5904 and MESOS-8564
> https://issues.apache.org/jira/browse/MESOS-5904
> https://issues.apache.org/jira/browse/MESOS-8564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This defaults to `os::PATH_SEPARATOR` and so by default retains the
> previous behavior. However, now `Path` can be arbitrarily used with,
> e.g., URLs on Windows by providing `/` as the separator.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d
>
>
> Diff: https://reviews.apache.org/r/67951/diff/1/
>
>
> Testing
> -------
>
> `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67951: Added optional `path_separator` parameter to
`Path` constructor.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/#review206181
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika Jandhyala
On July 17, 2018, 10:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67951/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 10:27 p.m.)
>
>
> Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
>
>
> Bugs: MESOS-5904 and MESOS-8564
> https://issues.apache.org/jira/browse/MESOS-5904
> https://issues.apache.org/jira/browse/MESOS-8564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This defaults to `os::PATH_SEPARATOR` and so by default retains the
> previous behavior. However, now `Path` can be arbitrarily used with,
> e.g., URLs on Windows by providing `/` as the separator.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d
>
>
> Diff: https://reviews.apache.org/r/67951/diff/1/
>
>
> Testing
> -------
>
> `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67951: Added optional `path_separator` parameter to
`Path` constructor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/#review206185
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67951']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1946/mesos-review-67951
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1946/mesos-review-67951/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (23) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\docker\docker.cpp(451): error C2280: 'Path &Path::operator =(const Path &)': attempting to reference a deleted function [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:14:39.94
```
- Mesos Reviewbot Windows
On July 17, 2018, 10:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67951/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 10:27 p.m.)
>
>
> Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
>
>
> Bugs: MESOS-5904 and MESOS-8564
> https://issues.apache.org/jira/browse/MESOS-5904
> https://issues.apache.org/jira/browse/MESOS-8564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This defaults to `os::PATH_SEPARATOR` and so by default retains the
> previous behavior. However, now `Path` can be arbitrarily used with,
> e.g., URLs on Windows by providing `/` as the separator.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d
>
>
> Diff: https://reviews.apache.org/r/67951/diff/1/
>
>
> Testing
> -------
>
> `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>