You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/11/18 14:00:06 UTC

Review Request 15646: CLOUDSTACK-5197: portable ip - Skipping the tests which are failing due to product issue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15646/
-----------------------------------------------------------

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-5197
    https://issues.apache.org/jira/browse/CLOUDSTACK-5197


Repository: cloudstack-git


Description
-------

2 test cases are failing while SSHing to the VM through portable ip. Logged a product defect for this - https://issues.apache.org/jira/browse/CLOUDSTACK-5196.
Skipping the test cases until the product defect is resolved.


Diffs
-----

  test/integration/component/test_portable_ip.py 14b6dac 

Diff: https://reviews.apache.org/r/15646/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request 15646: CLOUDSTACK-5197: portable ip - Skipping the tests which are failing due to product issue

Posted by Ashutosh Kelkar <as...@clogeny.com>.
No not a problem. I will remove the skip test decorator.




On Tue, Nov 19, 2013 at 9:43 AM, Prasanna Santhanam <ts...@apache.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15646/
>
> actually, don't skip issues that are valid failures. allow the test to fail until the root cause is addressed? is there a problem with this?
>
>
> - Prasanna Santhanam
>
> On November 18th, 2013, 1 p.m. UTC, Ashutosh Kelkar wrote:
>   Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao
> Talluri.
> By Ashutosh Kelkar.
>
> *Updated Nov. 18, 2013, 1 p.m.*
>  *Bugs: * CLOUDSTACK-5197<https://issues.apache.org/jira/browse/CLOUDSTACK-5197>
>  *Repository: * cloudstack-git
> Description
>
> 2 test cases are failing while SSHing to the VM through portable ip. Logged a product defect for this - https://issues.apache.org/jira/browse/CLOUDSTACK-5196.
> Skipping the test cases until the product defect is resolved.
>
>   Diffs
>
>    - test/integration/component/test_portable_ip.py (14b6dac)
>
> View Diff <https://reviews.apache.org/r/15646/diff/>
>

Re: Review Request 15646: CLOUDSTACK-5197: portable ip - Skipping the tests which are failing due to product issue

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15646/#review29098
-----------------------------------------------------------


actually, don't skip issues that are valid failures. allow the test to fail until the root cause is addressed? is there a problem with this?

- Prasanna Santhanam


On Nov. 18, 2013, 1 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15646/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 1 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5197
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5197
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 2 test cases are failing while SSHing to the VM through portable ip. Logged a product defect for this - https://issues.apache.org/jira/browse/CLOUDSTACK-5196.
> Skipping the test cases until the product defect is resolved.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_portable_ip.py 14b6dac 
> 
> Diff: https://reviews.apache.org/r/15646/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 15646: CLOUDSTACK-5197: portable ip - Skipping the tests which are failing due to product issue

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15646/
-----------------------------------------------------------

(Updated Nov. 19, 2013, 10:52 a.m.)


Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.


Changes
-------

Removing skip tag from test cases which are failing due to product issue.


Bugs: CLOUDSTACK-5197
    https://issues.apache.org/jira/browse/CLOUDSTACK-5197


Repository: cloudstack-git


Description
-------

2 test cases are failing while SSHing to the VM through portable ip. Logged a product defect for this - https://issues.apache.org/jira/browse/CLOUDSTACK-5196.
Skipping the test cases until the product defect is resolved.


Diffs (updated)
-----

  test/integration/component/test_portable_ip.py d397ec4 

Diff: https://reviews.apache.org/r/15646/diff/


Testing
-------


Thanks,

Ashutosh Kelkar