You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "philipnee (via GitHub)" <gi...@apache.org> on 2023/02/09 17:49:25 UTC

[GitHub] [kafka] philipnee opened a new pull request, #13225: KAFKA-6793

philipnee opened a new pull request, #13225:
URL: https://github.com/apache/kafka/pull/13225

   Reviving this old discussion, apparently the PR was closed so I reopened another one.
   
   **Issue**: Recently we've encountered complaints about the warning being too noisy, therefore we want to reduce it to debug level.
   
   The original PR was closed in : https://issues.apache.org/jira/browse/KAFKA-6793
   
   **Questions**
   Is this log useful at all? Should we just remove it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #13225: KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary

Posted by "hachikuji (via GitHub)" <gi...@apache.org>.
hachikuji merged PR #13225:
URL: https://github.com/apache/kafka/pull/13225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #13225: KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary

Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13225:
URL: https://github.com/apache/kafka/pull/13225#issuecomment-1427982683

   Huge +1 to demoting these. They've made the `WARN` level basically useless in Kafka Connect with the amount of noise they generate on startup, and the underlying strategy we use to track unused configs is just not intelligent enough to accommodate reasonable use cases like transparent passthrough of properties from one instantiated object to a plugin for it later on (i.e., after its `AbstractConfig` has already been instantiated).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] philipnee commented on pull request #13225: KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary

Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee commented on PR #13225:
URL: https://github.com/apache/kafka/pull/13225#issuecomment-1427130688

   Failing tests seem unrelated (also appear to be flaky)
   ```
   Build / JDK 17 and Scala 2.13 / testGracefulClose() – org.apache.kafka.clients.consumer.KafkaConsumerTest
   1s
   Build / JDK 17 and Scala 2.13 / [1] Type=ZK, Name=testMigrate, MetadataVersion=3.4-IV0, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest
   9s
   Build / JDK 8 and Scala 2.12 / testLargeAssignmentAndGroupWithNonEqualSubscription() – org.apache.kafka.clients.consumer.StickyAssignorTest
   1m 30s
   Build / JDK 8 and Scala 2.12 / [1] Type=ZK, Name=testMigrate, MetadataVersion=3.4-IV0, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest
   12s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] philipnee commented on pull request #13225: KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary

Posted by "philipnee (via GitHub)" <gi...@apache.org>.
philipnee commented on PR #13225:
URL: https://github.com/apache/kafka/pull/13225#issuecomment-1426247418

   @hachikuji - info level logging to prevent misleading warn.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org