[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

["Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117752#comment-13117752 ] 

Lars Hofhansl commented on HBASE-4501:
--------------------------------------

So is this just a matter of calling terminate in this case, or something more involved?
                
> [replication] Shutting down a stream leaves recovered sources running
> ---------------------------------------------------------------------
>
>                 Key: HBASE-4501
>                 URL: https://issues.apache.org/jira/browse/HBASE-4501
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.0
>
>
> When removing a peer it will call ReplicationSourceManager.removePeer which calls closeRecoveredQueue which does this:
> {code}
> LOG.info("Done with the recovered queue " + src.getPeerClusterZnode());
> this.oldsources.remove(src);
> this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
> {code}
> This works in the case where the recovered source is done and is calling this method, but when removing a peer it never calls terminate on thus it leaving it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira