[GitHub] [zeppelin] Reamer commented on a diff in pull request #4390: [ZEPPELIN-5757] Assume role in NotebookRepo S3

[GitBox <gi...@apache.org>]

Reamer commented on code in PR #4390:
URL: https://github.com/apache/zeppelin/pull/4390#discussion_r911031302


##########
zeppelin-plugins/notebookrepo/s3/pom.xml:
##########
@@ -34,15 +34,28 @@
     <description>NotebookRepo implementation based on S3</description>
 
     <properties>
-        <aws.sdk.s3.version>1.11.736</aws.sdk.s3.version>
+        <aws.sdk.version>1.11.736</aws.sdk.version>
         <plugin.name>NotebookRepo/S3NotebookRepo</plugin.name>
     </properties>
 
     <dependencies>
         <dependency>
             <groupId>com.amazonaws</groupId>
             <artifactId>aws-java-sdk-s3</artifactId>
-            <version>${aws.sdk.s3.version}</version>
+            <version>${aws.sdk.version}</version>
+            <exclusions>
+                <!-- jcl-over-slf4j is provided by zeppelin-interprerter -->
+                <exclusion>
+                    <groupId>commons-logging</groupId>
+                    <artifactId>commons-logging</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
+

Review Comment:
   Since you are not using the library in your code, you should leave a comment why it is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org