You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/09/22 03:17:03 UTC
[GitHub] [bigtop] kevinw66 opened a new pull request, #1021: BIGTOP-3823: Support parent directory configuration for HBase rpm build script
kevinw66 opened a new pull request, #1021:
URL: https://github.com/apache/bigtop/pull/1021
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
diff result:
```
753496 blocks
753496 blocks
2d1
< ./etc/hbase
10 blocks
10 blocks
27 blocks
27 blocks
10 blocks
10 blocks
10 blocks
10 blocks
10 blocks
10 blocks
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #1021: BIGTOP-3823: Support parent directory configuration for HBase rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1021:
URL: https://github.com/apache/bigtop/pull/1021#issuecomment-1263331029
Merged into master. Thanks @kevinw66!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] kevinw66 commented on pull request #1021: BIGTOP-3823: Support parent directory configuration for HBase rpm build script
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #1021:
URL: https://github.com/apache/bigtop/pull/1021#issuecomment-1263432374
> Oh, I've just found some debug messages after merging it. @kevinw66 would you submit a brief patch to remove them? https://github.com/apache/bigtop/pull/1022/files#diff-830b6899b86a1bb787661972ce4541597f14f09e39a973e1c8ae0b0225990a64R155-R157
Sorry, my bad, I'll remove them immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #1021: BIGTOP-3823: Support parent directory configuration for HBase rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1021:
URL: https://github.com/apache/bigtop/pull/1021#issuecomment-1263330529
+1, tested as follows:
```
$ ./gradlew hbase-clean hbase-pkg repo -Dbuildwithdeps=true
$ mv output/hbase /tmp
$ curl -sL https://github.com/apache/bigtop/pull/1021.diff | git apply
$ ./gradlew hbase-clean hbase-pkg repo -Dbuildwithdeps=true
$ for i in $(find output/hbase -name '*.rpm'); do diff <(rpm -qlp $i) <(rpm -qlp ${i/output/\/tmp}); done
2d1
< /etc/hbase
$ ./gradlew hbase-clean hbase-pkg repo -Dbuildwithdeps=true -PparentDir=/usr/bigtop
$ for i in $(find output/hbase/noarch output/hbase/x86_64 -name '*.rpm'); do rpm -qlp $i; done
/usr/bigtop/usr/share/doc/hbase-2.4.13
...
/etc/hbase
/etc/security/limits.d/hbase.nofiles.conf
/usr/bigtop/etc/default/hbase
/usr/bigtop/etc/hbase/conf.dist
/usr/bigtop/etc/hbase/conf.dist/hadoop-metrics2-hbase.properties
/usr/bigtop/etc/hbase/conf.dist/hbase-env.sh
/usr/bigtop/etc/hbase/conf.dist/hbase-policy.xml
/usr/bigtop/etc/hbase/conf.dist/hbase-site.xml
/usr/bigtop/etc/hbase/conf.dist/log4j-hbtop.properties
/usr/bigtop/etc/hbase/conf.dist/log4j.properties
/usr/bigtop/etc/hbase/conf.dist/regionservers
/usr/bigtop/usr/bin/hbase
/usr/bigtop/usr/lib/hbase
...
/usr/bigtop/var/lib/hbase
/var/log/hbase
/var/run/hbase
/etc/rc.d/init.d/hbase-regionserver
/etc/rc.d/init.d/hbase-thrift2
/etc/rc.d/init.d/hbase-master
/etc/rc.d/init.d/hbase-thrift
/etc/rc.d/init.d/hbase-rest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn merged pull request #1021: BIGTOP-3823: Support parent directory configuration for HBase rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn merged PR #1021:
URL: https://github.com/apache/bigtop/pull/1021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #1021: BIGTOP-3823: Support parent directory configuration for HBase rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1021:
URL: https://github.com/apache/bigtop/pull/1021#issuecomment-1263416725
Oh, I've just found some debug messages after merging it. @kevinw66 would you submit a brief patch to remove them?
https://github.com/apache/bigtop/pull/1022/files#diff-830b6899b86a1bb787661972ce4541597f14f09e39a973e1c8ae0b0225990a64R155-R157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org