You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 18:17:20 UTC
[GitHub] [spark] sunchao opened a new pull request #31462: SPARK-34347
sunchao opened a new pull request #31462:
URL: https://github.com/apache/spark/pull/31462
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR includes the following changes:
1. in `CatalogImpl.uncacheTable`, invalidate caches in cascade when the target table is
a temp view, and `spark.sql.legacy.storeAnalyzedPlanForView` is false (default value).
2. make `SessionCatalog.lookupTempView` public and return processed temp view plan (i.e., with `View` op).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Following [SPARK-34052](https://issues.apache.org/jira/browse/SPARK-34052) (#31107), we should invalidate in cascade for `CatalogImpl.uncacheTable` when the table is a temp view, so that the behavior is consistent.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, now `SQLContext.uncacheTable` will drop temp view in cascade by default.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r570011001
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -909,12 +909,12 @@ class SessionCatalog(
isTempView(nameParts.asTableIdentifier)
}
- private def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
+ def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
val tableName = formatTableName(name.table)
if (name.database.isEmpty) {
- tempViews.get(tableName)
+ tempViews.get(tableName).map(getTempViewPlan)
} else if (formatDatabaseName(name.database.get) == globalTempViewManager.database) {
- globalTempViewManager.get(tableName)
+ globalTempViewManager.get(tableName).map(getTempViewPlan)
Review comment:
Yes. This is added so we can pass a parsed view plan to `CatalogImpl.uncacheView`. I _think_ it also fixes a potential issue in `refreshTable` where `refresh` is called on `TemporaryViewRelation` instead of `View`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-776439223
Thanks! Merging to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772852355
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772852355
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773226837
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134858/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-775429482
Any more comments on this @viirya ? cc @dongjoon-hyun too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773065658
**[Test build #134858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134858/testReport)** for PR 31462 at commit [`27e8635`](https://github.com/apache/spark/commit/27e86350b7d3802db7e8fcd22e3ec732693570c6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772908000
**[Test build #134845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134845/testReport)** for PR 31462 at commit [`865cae9`](https://github.com/apache/spark/commit/865cae9fd43a2faad5c3ed1ce0584d24bee1e959).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773226837
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134858/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773065658
**[Test build #134858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134858/testReport)** for PR 31462 at commit [`27e8635`](https://github.com/apache/spark/commit/27e86350b7d3802db7e8fcd22e3ec732693570c6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #31462:
URL: https://github.com/apache/spark/pull/31462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772836160
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773080090
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39443/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r569758426
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
##########
@@ -1426,4 +1426,22 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
assert(e.message.contains(s"Table or view not found: $t"))
}
}
+
+ test("SPARK-34347: cascading cache invalidation - SQLContext.uncacheTable") {
+ Seq(true, false).foreach { storeAnalyzed =>
+ withSQLConf(SQLConf.STORE_ANALYZED_PLAN_FOR_VIEW.key -> storeAnalyzed.toString) {
+ withTempView("view1", "view2") {
+ sql("CREATE TEMPORARY VIEW view1 AS SELECT * FROM testData WHERE key > 1")
Review comment:
Good point. Will add test for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772781540
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773222554
**[Test build #134858 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134858/testReport)** for PR 31462 at commit [`27e8635`](https://github.com/apache/spark/commit/27e86350b7d3802db7e8fcd22e3ec732693570c6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773111769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r569995302
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -909,12 +909,12 @@ class SessionCatalog(
isTempView(nameParts.asTableIdentifier)
}
- private def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
+ def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
val tableName = formatTableName(name.table)
if (name.database.isEmpty) {
- tempViews.get(tableName)
+ tempViews.get(tableName).map(getTempViewPlan)
} else if (formatDatabaseName(name.database.get) == globalTempViewManager.database) {
- globalTempViewManager.get(tableName)
+ globalTempViewManager.get(tableName).map(getTempViewPlan)
Review comment:
Does this add a `View` wrapper which is not added previously?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-776330501
For clarification, it should be fine to merge it (and leave it for them to post-review).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773065658
**[Test build #134858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134858/testReport)** for PR 31462 at commit [`27e8635`](https://github.com/apache/spark/commit/27e86350b7d3802db7e8fcd22e3ec732693570c6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773065658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772750254
**[Test build #134845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134845/testReport)** for PR 31462 at commit [`865cae9`](https://github.com/apache/spark/commit/865cae9fd43a2faad5c3ed1ce0584d24bee1e959).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773111769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linhongliu-db commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-776408064
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772911798
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r569995302
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -909,12 +909,12 @@ class SessionCatalog(
isTempView(nameParts.asTableIdentifier)
}
- private def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
+ def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
val tableName = formatTableName(name.table)
if (name.database.isEmpty) {
- tempViews.get(tableName)
+ tempViews.get(tableName).map(getTempViewPlan)
} else if (formatDatabaseName(name.database.get) == globalTempViewManager.database) {
- globalTempViewManager.get(tableName)
+ globalTempViewManager.get(tableName).map(getTempViewPlan)
Review comment:
Does this add a `View` wrapper which is not added previously?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r569743607
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
##########
@@ -1426,4 +1426,22 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
assert(e.message.contains(s"Table or view not found: $t"))
}
}
+
+ test("SPARK-34347: cascading cache invalidation - SQLContext.uncacheTable") {
+ Seq(true, false).foreach { storeAnalyzed =>
+ withSQLConf(SQLConf.STORE_ANALYZED_PLAN_FOR_VIEW.key -> storeAnalyzed.toString) {
+ withTempView("view1", "view2") {
+ sql("CREATE TEMPORARY VIEW view1 AS SELECT * FROM testData WHERE key > 1")
Review comment:
How about `GLOBAL TEMPORARY VIEW` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #31462:
URL: https://github.com/apache/spark/pull/31462#discussion_r570011001
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -909,12 +909,12 @@ class SessionCatalog(
isTempView(nameParts.asTableIdentifier)
}
- private def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
+ def lookupTempView(name: TableIdentifier): Option[LogicalPlan] = {
val tableName = formatTableName(name.table)
if (name.database.isEmpty) {
- tempViews.get(tableName)
+ tempViews.get(tableName).map(getTempViewPlan)
} else if (formatDatabaseName(name.database.get) == globalTempViewManager.database) {
- globalTempViewManager.get(tableName)
+ globalTempViewManager.get(tableName).map(getTempViewPlan)
Review comment:
Yes. This is added so we can pass a parsed view plan to `CatalogImpl.uncacheView`. I _think_ it also fixes a potential issue in `refreshTable` where `refresh` is called on `TemporaryViewRelation` instead of `View`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772911798
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773111769
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39443/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-776324569
I'll merge this later if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773094628
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39443/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-773111769
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39443/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31462: [SPARK-34347][SQL] CatalogImpl.uncacheTable should invalidate in cascade for temp views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31462:
URL: https://github.com/apache/spark/pull/31462#issuecomment-772750254
**[Test build #134845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134845/testReport)** for PR 31462 at commit [`865cae9`](https://github.com/apache/spark/commit/865cae9fd43a2faad5c3ed1ce0584d24bee1e959).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org