You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ljader <gi...@git.apache.org> on 2018/11/18 14:57:00 UTC
[GitHub] tomcat pull request #134: Display generate date when showing every message i...
GitHub user ljader opened a pull request:
https://github.com/apache/tomcat/pull/134
Display generate date when showing every message in Html Manager
This additions shows sample message in following format:
```
OK - Stopped application at context path [/app]
Generated at: 2018-11-18 14:44:08 UTC (2018-11-18 15:44:08 VM time)
```
**Why the addition:**
Often when I connect into our legacy servers with Windows RDP client,
I intercept existing session where the Tomcat Manager was open in the browser.
With current Tomcat Manager output I have no way of knowing **when** the Message shown was generated - was it 10 seconds ago or yesterday?
I welcome any feedback on this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ljader/tomcat add_message_generate_date
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit 41b7367f0e321608f23d3d5fb4d193543b0b7efa
Author: Lukasz Jader <lj...@...>
Date: 2018-11-18T14:45:25Z
Display generate date when showing every message in Html Manager
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by ljader <gi...@git.apache.org>.
Github user ljader commented on the issue:
https://github.com/apache/tomcat/pull/134
Thank you all for the comments - could you help me with getting them right?
1. How I can get the "Date" header without reloading the page when the DevTools are **closed** (by default)?
2. Doesn't the "Modified" section in "Right-click + Pageinfo" in Firefox shows **every time a different** date ?
If yes, then I can's see how it's helpfull.
3. I think I don't get why someone would like to checksum the response of Html Manager - can you give some examples? Isn't the `manager/text` designed to automate?
Thinking about my 3rd question, I want to clarify that my change only affects (or what I originaly intended)
is to change only the `manager/html` - NOT the `manager/text`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/134
I tried adding a Last-Modified HTTP header but that didn't help. The history approach looks to be the best solution at this point.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by rmaucher <gi...@git.apache.org>.
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/134
Correct, this doesn't give the right info, I thought it did. Still not that convinced though, you don't see that kind of timestamp often (if at all), right ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by rmaucher <gi...@git.apache.org>.
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/134
I'm not convinced by the use case, so I don't see why this one adds something useful. Right-click + pageinfo wouldn't show the needed info ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/134
> How I can get the "Date" header without reloading the page when the DevTools are closed (by default)?
As far as I can see, you can't
> Doesn't the "Modified" section in "Right-click + Pageinfo" in Firefox shows every time a different date ?
If yes, then I can's see how it's helpfull.
Correct, that information is quite pointless.
> I think I don't get why someone would like to checksum the response of Html Manager - can you give some examples?
While this is correct, we don't know what people are doing with the manager.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by ljader <gi...@git.apache.org>.
Github user ljader commented on the issue:
https://github.com/apache/tomcat/pull/134
When it comes to checksuming the response of Html Manager, recently there was a Pull Request which added 2 nbsp's to the produced Html - #130
If you decide to not proceed with this change, consider if the mentioned PR should be reverted.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/134
The browser history will give you what you need (to the minute anyway) in both Chrome Firefox and IE. This is a generic solution that works for any web page for any service - not just one page of the Tomcat Manager app. I'm still looking into why the browser doesn't show a last modified date.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/134
I agree with @rmaucher, I see little benefit here. This not static content, but dynamic. We have browser info and the {{Date}} header. For those who want to checksum the response, this change will break it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/134
@ljader, why? This is a static change, not a dynamic one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/134
How easy it is to get hold of the last modified date does vary by browser but - given that Tomcat already provides this in the headers - I don't see much benefit here. And micheal-o's comment on checksumming is a valid one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org