You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/03/27 15:06:25 UTC

[Bug 59240] New: Introduce a slf4j binding for Logback

https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

            Bug ID: 59240
           Summary: Introduce a slf4j binding for Logback
           Product: JMeter
           Version: 2.13
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: p.mouawad@ubik-ingenierie.com

Currently JMeter uses nop binder which hides sometimes interesting logs.
The idea of this bug is to introduce a static binder for Logback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j adapter for Logkit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

--- Comment #9 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Tue Apr 19 11:30:31 2016
New Revision: 1739903

URL: http://svn.apache.org/viewvc?rev=1739903&view=rev
Log:
59240 Introduce a slf4j adapter for Logkit (this allows using slf4j within
plugins and core code)
Make LogkitLoggerAdapter Serializable
Bugzilla Id: 59240

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerFactory.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j adapter for Logkit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #7 from Sebb <se...@apache.org> ---
Some of the new classes need to be renamed and the Javadocs adjusted to avoid
confusing future maintainers as to the purpose of the classes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j binding for Logback

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Mar 27 13:24:35 2016
New Revision: 1736749

URL: http://svn.apache.org/viewvc?rev=1736749&view=rev
Log:
Bug 59240 - Introduce a slf4j binding for Logback
svn:eol
Bugzilla Id: 59240

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java  
(props changed)
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java  
(props changed)
    jmeter/trunk/src/core/org/slf4j/impl/StaticLoggerBinder.java   (props
changed)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j adapter for Logkit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Introduce a slf4j binding   |Introduce a slf4j adapter
                   |for Logback                 |for Logkit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j adapter for Logkit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Mon Mar 28 17:04:08 2016
New Revision: 1736907

URL: http://svn.apache.org/viewvc?rev=1736907&view=rev
Log:
Bug 59240 - Introduce a slf4j adapter for Logkit
Rename classes
Bugzilla Id: 59240

Added:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java  
(contents, props changed)
      - copied, changed from r1736749,
jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerFactory.java  
(contents, props changed)
      - copied, changed from r1736749,
jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java
Removed:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java
Modified:
    jmeter/trunk/src/core/org/slf4j/impl/StaticLoggerBinder.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j adapter for Logkit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

--- Comment #6 from Ceki Gulcu <ce...@apache.org> ---
By the way, you might find the slf4j-migrator useful when migrating the logkit
calls to slf4j. You would need to tweak it a little but it should be more than
feasible and would save you time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j adapter for Logkit

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Ceki Gulcu from comment #4)
> I think you mean an SLF4J adapter for logkit, not logback, which has a
> native implementation of slf4j-api.

Thanks Ceki for your attention :-) 
Indeed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j binding for Logback

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Mar 27 13:09:58 2016
New Revision: 1736745

URL: http://svn.apache.org/viewvc?rev=1736745&view=rev
Log:
Bug 59240 - Introduce a slf4j binding for Logback
Bugzilla Id: 59240

Added:
    jmeter/trunk/src/core/org/apache/jmeter/logging/
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java  
(with props)
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java  
(with props)
    jmeter/trunk/src/core/org/slf4j/
    jmeter/trunk/src/core/org/slf4j/impl/
    jmeter/trunk/src/core/org/slf4j/impl/StaticLoggerBinder.java   (with props)
Modified:
    jmeter/trunk/build.xml
    jmeter/trunk/eclipse.classpath
    jmeter/trunk/lib/   (props changed)
    jmeter/trunk/lib/aareadme.txt
    jmeter/trunk/res/maven/ApacheJMeter_parent.pom
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j binding for Logback

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

--- Comment #4 from Ceki Gulcu <ce...@apache.org> ---
I think you mean an SLF4J adapter for logkit, not logback, which has a native
implementation of slf4j-api.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59240] Introduce a slf4j binding for Logback

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59240

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Mar 27 13:11:22 2016
New Revision: 1736747

URL: http://svn.apache.org/viewvc?rev=1736747&view=rev
Log:
Bug 59240 - Introduce a slf4j binding for Logback
Bugzilla Id: 59240

Modified:
    jmeter/trunk/build.properties

-- 
You are receiving this mail because:
You are the assignee for the bug.