[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r933406917


##########
client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java:
##########
@@ -65,4 +65,8 @@ public class RssClientConfig {
   public static final int RSS_ACCESS_TIMEOUT_MS_DEFAULT_VALUE = 10000;
   public static final String RSS_DYNAMIC_CLIENT_CONF_ENABLED = "rss.dynamicClientConf.enabled";
   public static final boolean RSS_DYNAMIC_CLIENT_CONF_ENABLED_DEFAULT_VALUE = true;
+
+  public static final String RSS_CLIENT_ASSIGNMENT_SHUFFLE_SERVER_NUMBER =
+      "rss.client.assignment.shuffle.server.number";

Review Comment:
   `rss.client.assignment.shuffle.node.max`
   Could we use  a similar style name with the coordinator's configuration?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org