You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/17 18:18:20 UTC
[GitHub] [incubator-yunikorn-k8shim] craigcondit opened a new pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
craigcondit opened a new pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391
### What is this PR for?
The core changes for YUNIKORN-165 (returning resources in REST API as map objects) require changes to the e2e tests to avoid failures. This PR makes those updates.
TODO: Draft due to core PR not merged yet
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-165
### How should this be tested?
E2e tests now pass.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391#issuecomment-1074066839
Closing in favor of new JIRA in YUNIKORN-1120.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391#issuecomment-1071216190
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#391](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d6642c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/527f4d1ca62b046d0c0c976391024240ee8abfb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (527f4d1) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 65.84% 65.84%
=======================================
Files 40 40
Lines 6230 6230
=======================================
Hits 4102 4102
Misses 1973 1973
Partials 155 155
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [527f4d1...6d6642c](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit closed pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391#issuecomment-1072073183
Craig: I think we need to move this to a new jira to update the e2e tests for YUNIKORN-165 and YUNIKORN-1120 in one update. We need to include a go.mod change to pull the latest version of the core into the shim.
The pseudo version to vhange to should be: `v0.0.0-20220318052402-b3dfd0d2adaa`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391#issuecomment-1071216190
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#391](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d6642c) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/527f4d1ca62b046d0c0c976391024240ee8abfb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (527f4d1) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 65.84% 65.84%
=======================================
Files 40 40
Lines 6230 6230
=======================================
Hits 4102 4102
Misses 1973 1973
Partials 155 155
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [527f4d1...6d6642c](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/391?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #391: [YUNIKORN-165] Consume new map-based REST API resource fields in e2e tests
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #391:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/391#issuecomment-1072073183
Craig: I think we need to move this to a new jira to update the e2e tests for YUNIKORN-165 and YUNIKORN-1120 in one update. We need to include a go.mod change to pull the latest version of the core into the shim.
The pseudo version to vhange to should be: `v0.0.0-20220318052402-b3dfd0d2adaa`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org