You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 10:33:35 UTC

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #249: Fix reference page 404 issue

SignorMercurio opened a new pull request, #249:
URL: https://github.com/apache/pulsar-site/pull/249

   Fix apache/pulsar#17996.
   
   
   Also change versions like `2.6.0` to `2.6.x`, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1274614437

   @SignorMercurio how can I verify this change locally?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275662268

   <img width="1728" alt="image" src="https://user-images.githubusercontent.com/18818196/195267377-61d9d39b-e5c8-432d-a8d1-2c1f3a97c3da.png">
   
   Still not found. I think when you're running `docsify serve`, it runs a new server serving the source files, while serves them as static file, markdown files and other meta files aren't recognized anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275671883

   Found:
   
   ```bash
   # Generate document for command line tools.
   "$TOOLS_DIR"/pulsar-admin-doc-gen.sh "$WEBSITE_DIR" "$VERSION"
   "$TOOLS_DIR"/pulsar-client-doc-gen.sh "$WEBSITE_DIR" "$VERSION"
   "$TOOLS_DIR"/pulsar-perf-doc-gen.sh "$WEBSITE_DIR" "$VERSION"
   "$TOOLS_DIR"/pulsar-doc-gen.sh "$WEBSITE_DIR" "$VERSION"
   "$TOOLS_DIR"/pulsar-config-doc-gen.sh "$WEBSITE_DIR" "$VERSION"
   cd "$WEBSITE_DIR"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275667515

   Verified locally. Although not a fully integration, we can give it a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1274917692

   @SignorMercurio this command verifies only the docsify site itself. How can I ensure that it's properly integrated with the Pulsar site? Said you state that 404 issues are resolved, it's actually about the integration instead of docsify standalone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] SignorMercurio commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275562317

   @tisonkun I haven't figured out an elegant way to do this, but you may try start a local HTTP server like this:
   
   1. Create a temporary directory `website`:
   
   ```shell
   $ mkdir /tmp/website
   ```
   
   2. Copy the `docsify` directory to `website`:
   
   ```shell
   $ cd site2/website-next
   $ cp -r docsify /tmp/website/reference
   ```
   
   3. Start a local HTTP server under `website`:
   
   ```shell
   $ python3 -m http.server
   ```
   
   4. Access http://localhost:8000/reference and you should see the new reference page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] SignorMercurio commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1274777006

   @tisonkun Simply go to `docsify` directory and run `docsify serve`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275622871

   @SignorMercurio This still tests only the docsify site instead of the integration with Pulsar website - you don't start a local server serving the doc site. And what is to be tested is jumping from the doc site to the reference pages correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] urfreespace merged pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
urfreespace merged PR #249:
URL: https://github.com/apache/pulsar-site/pull/249


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] SignorMercurio commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275768954

   > There're other 404 pages, please check whether they're generated on the fly?
   
   Yes, they are.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on pull request #249: Fix reference page 404 issue

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #249:
URL: https://github.com/apache/pulsar-site/pull/249#issuecomment-1275669613

   <img width="1728" alt="image" src="https://user-images.githubusercontent.com/18818196/195268739-d54001cc-d743-4174-b219-591541123bbe.png">
   
   * http://localhost:8000/reference/#/latest/pulsar-admin/broker-stats
   
   There're other 404 pages, please check whether they're generated on the fly?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org