You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/29 04:08:33 UTC
[GitHub] [apisix-docker] juzhiyuan opened a new pull request #81: feat: remove Dashboard
juzhiyuan opened a new pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] moonming merged pull request #81: feat: remove Dashboard
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] membphis commented on pull request #81: feat: remove Dashboard
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81#issuecomment-718375264
please confirm we run `alpine/Dockerfile` in CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on pull request #81: feat: remove Dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81#issuecomment-718377923
> please confirm we run `alpine/Dockerfile` in CI
https://github.com/apache/apisix-docker/blob/feat-remove-dashboard/example/docker-compose-alpine.yml#L7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #81: feat: remove Dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81#discussion_r513947957
##########
File path: alpine/Dockerfile
##########
@@ -7,10 +7,6 @@ RUN set -x \
&& apk add --no-cache --virtual .build-deps git \
&& git clone -b ${APISIX_VERSION} https://github.com/apache/apisix.git /tmp/apisix \
&& cd /tmp/apisix \
Review comment:
cc @membphis Not sure if this line should be removed, if yes, kindly remove it from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #81: feat: remove Dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81#discussion_r513947957
##########
File path: alpine/Dockerfile
##########
@@ -7,10 +7,6 @@ RUN set -x \
&& apk add --no-cache --virtual .build-deps git \
&& git clone -b ${APISIX_VERSION} https://github.com/apache/apisix.git /tmp/apisix \
&& cd /tmp/apisix \
Review comment:
cc @moonming Not sure if this line should be removed, if yes, kindly remove it from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] moonming commented on a change in pull request #81: feat: remove Dashboard
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #81:
URL: https://github.com/apache/apisix-docker/pull/81#discussion_r513959976
##########
File path: alpine/Dockerfile
##########
@@ -7,10 +7,6 @@ RUN set -x \
&& apk add --no-cache --virtual .build-deps git \
&& git clone -b ${APISIX_VERSION} https://github.com/apache/apisix.git /tmp/apisix \
&& cd /tmp/apisix \
Review comment:
we can remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org