You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/09/03 22:58:35 UTC

[Impala-ASF-CR] IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui 

Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14174


Change subject: IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui
......................................................................

IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui

Manually refreshing a page when auto-refresh is turned off leaves the
auto-refresh checkbox unchecked but turns auto-refresh back on, which
also makes it difficult to turn auto-refresh back off.

The fix is to check the value of the checkbox on page load on all
pages that support auto-refresh.

This patch also modifies /query_backends and /query_finstances to
set the value for 'last-updated' on page load.

Testing:
- Manually verified it works as expected now.

Change-Id: I153de91eb21fe59a246ba4b5ecfad0d341d1fbee
---
M www/common-header.tmpl
M www/query_backends.tmpl
M www/query_finstances.tmpl
M www/query_summary.tmpl
M www/rpcz.tmpl
5 files changed, 20 insertions(+), 46 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/14174/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I153de91eb21fe59a246ba4b5ecfad0d341d1fbee
Gerrit-Change-Number: 14174
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14174 )

Change subject: IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4456/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153de91eb21fe59a246ba4b5ecfad0d341d1fbee
Gerrit-Change-Number: 14174
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Sep 2019 23:39:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/14174 )

Change subject: IMPALA-8916: Fix auto-refresh/manual refresh interaction on webui
......................................................................


Abandoned

This appears to be a Firefox specific issue. I'm not sure if we have official guidance about what browsers we support, but presumably basically all users use Chrome anyways, so this is pretty low priority.
-- 
To view, visit http://gerrit.cloudera.org:8080/14174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I153de91eb21fe59a246ba4b5ecfad0d341d1fbee
Gerrit-Change-Number: 14174
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>