You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Lefty Leverenz (JIRA)" <ji...@apache.org> on 2014/08/05 09:57:12 UTC
[jira] [Commented] (HIVE-7605) add more javadoc to
HivePrivilegeObject
[ https://issues.apache.org/jira/browse/HIVE-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085958#comment-14085958 ]
Lefty Leverenz commented on HIVE-7605:
--------------------------------------
One nitpick and one possible typo in patch 1:
{quote}
+ * Note that GLOBAL, PARTITION, COLUMN fields are populated only for hive's old default
+ * authorization mode.
{quote}
Please capitalize Hive.
{quote}
+ * @return return partiton key information. Used only for old default authorization mode.
{quote}
Since that's for getPartKeys, I suspect "return" shouldn't occur twice.
> add more javadoc to HivePrivilegeObject
> ---------------------------------------
>
> Key: HIVE-7605
> URL: https://issues.apache.org/jira/browse/HIVE-7605
> Project: Hive
> Issue Type: Improvement
> Components: Authorization
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Attachments: HIVE-7605.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)