Delete confirmations

[Kevin Menard <km...@servprise.com>]

Hi all,

I've just committed a fix for CAY-1011: Add confirmation dialog for delete
actions.  This required a lot more changes to the modeler than I've ever
done before.  Additionally, I had to make some changes to make the callbacks
and listeners work similarly to attributes, relationships, etc.

I've tested a fair bit and it appears work fine.  But, any beatings would be
much appreciated.

Thanks,
Kevin 

Re: Delete confirmations

[Damian Johnson <at...@gmail.com>]

The ConfirmDeleteDialog uses the default constructor and seems to rely on
shouldDelete(String, String) for the dialog's properties. However, the
show() method uses 'type' and 'name' without checking if they've been set or
not. Is this intended? It seems like the show method should either be
private or a static call should be made in place of both methods (since the
purpose of the dialog is centered around the shouldDelete method and
instances of the dialog are useless by themselves). -Damian

On Sat, Mar 22, 2008 at 2:33 PM, Kevin Menard <km...@servprise.com> wrote:

> Hi all,
>
> I've just committed a fix for CAY-1011: Add confirmation dialog for delete
> actions.  This required a lot more changes to the modeler than I've ever
> done before.  Additionally, I had to make some changes to make the
> callbacks
> and listeners work similarly to attributes, relationships, etc.
>
> I've tested a fair bit and it appears work fine.  But, any beatings would
> be
> much appreciated.
>
> Thanks,
> Kevin
>
>