You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by Masashi Takeichi <ta...@nttdata.co.jp> on 2004/06/16 08:46:27 UTC

Re[2]: JMeterThread initialization (additional comments)

Sorry, 
attachments seems to be removed.

The patch files of the previous mail are the followings.

[JMeterThraed.diff]
-----------------------------------
221a222,234
> 	try
> 	{
> 		synchronized(this.notifier)
> 		{
> 			System.out.println("Ready state. Wait to be
notified...");
> 			this.notifier.wait();
> 			System.out.println("Notified.");
> 		}
> 	}
> 	catch(InterruptedException exp)
> 	{
> 		exp.printStackTrace();
> 	}
-----------------------------------


[StandardJMeterEngine.diff]
-----------------------------------
354a355,371
>         
>         //Wait for all JMeterThreads to be ready
>         //In this version, the wait time is fixed value. 
>         try 
>         {
>         	System.out.println("Wait for all JMeterThread to be ready...");
>         	Thread.sleep(5000);
>         	synchronized(this.notifier)
>         	{
>         		this.notifier.notifyAll();
>         		System.out.println("NofifyAll!");
>         	}
>         } 
>         catch (InterruptedException e) 
>         { 
>         	e.printStackTrace(); 
>         }
-----------------------------------


Thank you.


On Wed, 16 Jun 2004 15:22:44 +0900
Masashi Takeichi <ta...@nttdata.co.jp> wrote:

> Hi
> 
> I'll propose a solution for 'JMeterThread initialization' issue.
> 
> This will enable all the JMeterThread to start at the same time as possible.
> As a result, rampup timings will become more accurate.
> 
> 
> My proposal consists of the following changes
>  1) [JMeterThread] All the JMeterThreads wait to be notified 
>      by JMeterEngine, after they are ready.
>  2) [StandarJMeterEngine] JMeterEngine notifies JMeterThreads all together.
> 
> Attachments are patch files for demonstrating this solution's effect.
> 
>  [CAUTION]
>    src version : 2.0.1
>    These patches are very simple implementations, just for demonstrating.
>    So they have some problems that must be fixed.
>        
> Please let me hear your comments.
> 
> Thank you.
> 
> 
> 
> -----------------------------------------
>  Masashi Takeichi <ta...@nttdata.co.jp>
> 
> 
> On Mon, 14 Jun 2004 21:17:15 +0900
> Masashi Takeichi <ta...@nttdata.co.jp> wrote:
> 
> > Hello 
> > 
> > May I ask you a question about StandardJMeterEngine?
> > 
> > I made my custom Sampler and plugged into JMeter.
> > Its constructor accesses some files to configure itself.
> > And it takes about 500 milliseconds.
> > 
> > I thought that the processing cost doesn't affect 
> > a performance of JMeter.
> > But actually, rampup timings were later than what were expected.
> > 
> > 
> > In StandardJMeterEngine.run() method [316-344],
> > JMeterThreads are created, configured and started in turn.
> > So the longer time it takes to construct and configure,
> > the later the rampup timings are.
> > 
> > I think that this problem is solvable in the following change
> > of StandardJMeterEngine.
> > 
> >   After all the JMeterThreads for a TestPlan are ready, 
> >   StandardJMeterEngine call Thread.start() for each JMeterThread.
> > 
> > 
> > Can I get some feedback on this?
> > 
> > Thank you.
> > 
> > 
> > 
> > -----------------------------------------
> >  Masashi Takeichi <ta...@nttdata.co.jp>
> 
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org