You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/23 01:34:10 UTC

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor

zhiics commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5128#discussion_r396176363
 
 

 ##########
 File path: include/tvm/relay/adt.h
 ##########
 @@ -91,13 +91,9 @@ class PatternVar;
 /*! \brief PatternVar container node */
 
 Review comment:
   @tqchen Do we want to move `make` in `PatternWildcardNode` to `PatternWildcard`? There is already a default constructor for `PatternWildcard`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services