[lucene-solr] branch master updated: SOLR-13322: Properly log exceptions.

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 863d34b  SOLR-13322: Properly log exceptions.
863d34b is described below

commit 863d34bff5ce8449c9bfae35acf1ab5746ace35d
Author: Andrzej Bialecki <ab...@apache.org>
AuthorDate: Thu Mar 21 22:21:21 2019 +0100

    SOLR-13322: Properly log exceptions.
---
 .../src/java/org/apache/solr/handler/admin/MetricsHistoryHandler.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/java/org/apache/solr/handler/admin/MetricsHistoryHandler.java b/solr/core/src/java/org/apache/solr/handler/admin/MetricsHistoryHandler.java
index 7dd8e4f..05c31e8 100644
--- a/solr/core/src/java/org/apache/solr/handler/admin/MetricsHistoryHandler.java
+++ b/solr/core/src/java/org/apache/solr/handler/admin/MetricsHistoryHandler.java
@@ -434,7 +434,7 @@ public class MetricsHistoryHandler extends RequestHandlerBase implements Permiss
           }
         }
       } catch (Exception e) {
-        e.printStackTrace();
+        log.warn("Exception retrieving local metrics for group {}: {}", group, e);
       }
     }
   }
@@ -580,6 +580,7 @@ public class MetricsHistoryHandler extends RequestHandlerBase implements Permiss
             s.update();
           }
         } catch (Exception e) {
+          log.warn("Exception storing sample in RrdDb for group {}: {}", group, e);
         }
       });
     });
@@ -632,6 +633,7 @@ public class MetricsHistoryHandler extends RequestHandlerBase implements Permiss
         RrdDb newDb = new RrdDb(def, factory);
         return newDb;
       } catch (IOException e) {
+        log.warn("Can't create RrdDb for registry {}, group {}: {}", registry, group, e);
         return null;
       }
     });