[jira] [Commented] (PIG-3024) TestEmptyInputDir unit test - hadoop version detection logic is brittle

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546480#comment-13546480 ] 

Rohini Palaniswamy commented on PIG-3024:
-----------------------------------------

{code}
if (Util.isHadoop23() || Util.isHadoop205())
{code}
I think you meant Hadoop2_0 (Util.isHadoop2_0()) and not Util.isHadoop205 because the assert will fail with that.

Do you need this in 0.11 or it can be moved to 0.12?
                
> TestEmptyInputDir unit test - hadoop version detection logic is brittle
> -----------------------------------------------------------------------
>
>                 Key: PIG-3024
>                 URL: https://issues.apache.org/jira/browse/PIG-3024
>             Project: Pig
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.10.0
>            Reporter: John Gordon
>            Assignee: John Gordon
>            Priority: Minor
>             Fix For: 0.11
>
>         Attachments: PIG-3024.branch-0.10.1.patch
>
>
> When the hadoop core version dependency is changed, TestEmptyInputDir almost always fails as coded.  The issue is that it assumes all hadoop versions  have MAPREDUCE-3606 fixed except two.  It is more resilient to check families of releases for the fix than to check the release number directly.  Right now, it is safer to assume the bug is present unless the release is one of those with the fix than it is to assume all releases have the fix except for two.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira