You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2016/01/16 11:58:27 UTC
svn commit: r1724954 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
Author: deepak
Date: Sat Jan 16 10:58:26 2016
New Revision: 1724954
URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
Log:
(OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
============================================================
Session already invalidate (removeAttribute: Session already invalidated) on destroyCart for anonymous userLogin
============================================================
Thanks Ankush for your contribution.
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java Sat Jan 16 10:58:26 2016
@@ -937,12 +937,13 @@ public class ShoppingCartEvents {
/** Totally wipe out the cart, removes all stored info. */
public static String destroyCart(HttpServletRequest request, HttpServletResponse response) {
HttpSession session = request.getSession();
- clearCart(request, response);
session.removeAttribute("shoppingCart");
session.removeAttribute("orderPartyId");
session.removeAttribute("orderMode");
session.removeAttribute("productStoreId");
session.removeAttribute("CURRENT_CATALOG_ID");
+ // Call clearCart at the end as if user is anonymous then it will throw session already invalidated error on removeAttribute method.
+ clearCart(request, response);
return "success";
}
Re: svn commit: r1724954 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Thanks Jacques, I'll look into it and try to fix the actual cause.
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Tue, Jan 19, 2016 at 10:14 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Checked: https://ci.apache.org/builders/ofbiz-trunk/builds/360
>
> Jacques
>
>
> Le 19/01/2016 17:11, Jacques Le Roux a écrit :
>
>> Sorry Deepak,
>>
>> The weird things with tests is that
>> https://ci.apache.org/builders/ofbiz-trunk/builds/351
>> is OK but
>> https://ci.apache.org/builders/ofbiz-trunk/builds/352
>> is not
>> But actually I just spotted there were 2 changes in this build
>> https://ci.apache.org/builders/ofbiz-trunk/builds/352#changes-
>>
>> I locally reverted r1724954 and tests passed, I will revert it on trunk
>> now and will reopen OFBIZ-6805
>>
>> It's maybe the right direction and the problem is in
>> testCreateOrderConfigurableServiceProduct
>> Being buzzy on other stuff I did not get a chance to look further yet
>>
>> Jacques
>>
>> Le 18/01/2016 11:51, Deepak Dixit a écrit :
>>
>>> Hi Jacques,
>>>
>>> I dig into it and found that its was not broken due to mentioned commit,
>>> I
>>> reverted it and still its broken.
>>> Its due to because initializeOrderEntry returns error as product store
>>> not
>>> found in request.
>>>
>>> {code}
>>>
>>> [java] 2016-01-18 16:14:03,129 |main
>>> |ProductStoreWorker |E| No product store found in request,
>>> cannot set locale!
>>>
>>> {code}
>>>
>>>
>>>
>>>
>>>
>>> Thanks & Regards
>>> --
>>> Deepak Dixit
>>> www.hotwaxsystems.com
>>>
>>> On Mon, Jan 18, 2016 at 10:28 AM, Deepak Dixit <
>>> deepak.dixit@hotwaxsystems.com> wrote:
>>>
>>> Thanks Jacques for reporting , Let me check.
>>>>
>>>> Thanks & Regards
>>>> --
>>>> Deepak Dixit
>>>> www.hotwaxsystems.com
>>>>
>>>> On Sun, Jan 17, 2016 at 4:38 AM, Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>> Le 17/01/2016 00:07, Jacques Le Roux a écrit :
>>>>>
>>>>> I did not dive into details but
>>>>>> testCreateOrderConfigurableServiceProduct reports an issue with this
>>>>>> change.
>>>>>> It was not obvious to me initially because thought Buildbot stopped
>>>>>> there https://ci.apache.org/builders/ofbiz-trunk it did not report
>>>>>> the
>>>>>> error in tests https://ci.apache.org/projects/ofbiz/logs/
>>>>>> I will check that and will add R15.12 soon in Buildbot
>>>>>> I got the error in Windows w/ another one
>>>>>> (service-xml-rpc-local-engine)
>>>>>> so I checked in Linux and got only the
>>>>>> testCreateOrderConfigurableServiceProduct error
>>>>>> I did not check details but I guess the same appears in R14.12:
>>>>>> https://ci.apache.org/builders/ofbiz-branch14
>>>>>>
>>>>>> And of course R15.12
>>>>>
>>>>>
>>>>>
>>>>> Jacques
>>>>>>
>>>>>> Le 16/01/2016 11:58, deepak@apache.org a écrit :
>>>>>>
>>>>>> Author: deepak
>>>>>>> Date: Sat Jan 16 10:58:26 2016
>>>>>>> New Revision: 1724954
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
>>>>>>> Log:
>>>>>>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
>>>>>>> ============================================================
>>>>>>> Session already invalidate (removeAttribute: Session already
>>>>>>> invalidated) on destroyCart for anonymous userLogin
>>>>>>> ============================================================
>>>>>>>
>>>>>>> Thanks Ankush for your contribution.
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>>> URL:
>>>>>>>
>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
>>>>>>>
>>>>>>>
>>>>>>> ==============================================================================
>>>>>>> ---
>>>>>>>
>>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>>> (original)
>>>>>>> +++
>>>>>>>
>>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>>> Sat Jan 16 10:58:26 2016
>>>>>>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
>>>>>>> /** Totally wipe out the cart, removes all stored info. */
>>>>>>> public static String destroyCart(HttpServletRequest request,
>>>>>>> HttpServletResponse response) {
>>>>>>> HttpSession session = request.getSession();
>>>>>>> - clearCart(request, response);
>>>>>>> session.removeAttribute("shoppingCart");
>>>>>>> session.removeAttribute("orderPartyId");
>>>>>>> session.removeAttribute("orderMode");
>>>>>>> session.removeAttribute("productStoreId");
>>>>>>> session.removeAttribute("CURRENT_CATALOG_ID");
>>>>>>> + // Call clearCart at the end as if user is anonymous then it
>>>>>>> will throw session already invalidated error on removeAttribute
>>>>>>> method.
>>>>>>> + clearCart(request, response);
>>>>>>> return "success";
>>>>>>> }
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>
Re: svn commit: r1724954 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Checked: https://ci.apache.org/builders/ofbiz-trunk/builds/360
Jacques
Le 19/01/2016 17:11, Jacques Le Roux a écrit :
> Sorry Deepak,
>
> The weird things with tests is that
> https://ci.apache.org/builders/ofbiz-trunk/builds/351
> is OK but
> https://ci.apache.org/builders/ofbiz-trunk/builds/352
> is not
> But actually I just spotted there were 2 changes in this build
> https://ci.apache.org/builders/ofbiz-trunk/builds/352#changes-
>
> I locally reverted r1724954 and tests passed, I will revert it on trunk now and will reopen OFBIZ-6805
>
> It's maybe the right direction and the problem is in testCreateOrderConfigurableServiceProduct
> Being buzzy on other stuff I did not get a chance to look further yet
>
> Jacques
>
> Le 18/01/2016 11:51, Deepak Dixit a écrit :
>> Hi Jacques,
>>
>> I dig into it and found that its was not broken due to mentioned commit, I
>> reverted it and still its broken.
>> Its due to because initializeOrderEntry returns error as product store not
>> found in request.
>>
>> {code}
>>
>> [java] 2016-01-18 16:14:03,129 |main
>> |ProductStoreWorker |E| No product store found in request,
>> cannot set locale!
>>
>> {code}
>>
>>
>>
>>
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxsystems.com
>>
>> On Mon, Jan 18, 2016 at 10:28 AM, Deepak Dixit <
>> deepak.dixit@hotwaxsystems.com> wrote:
>>
>>> Thanks Jacques for reporting , Let me check.
>>>
>>> Thanks & Regards
>>> --
>>> Deepak Dixit
>>> www.hotwaxsystems.com
>>>
>>> On Sun, Jan 17, 2016 at 4:38 AM, Jacques Le Roux <
>>> jacques.le.roux@les7arts.com> wrote:
>>>
>>>> Le 17/01/2016 00:07, Jacques Le Roux a écrit :
>>>>
>>>>> I did not dive into details but
>>>>> testCreateOrderConfigurableServiceProduct reports an issue with this change.
>>>>> It was not obvious to me initially because thought Buildbot stopped
>>>>> there https://ci.apache.org/builders/ofbiz-trunk it did not report the
>>>>> error in tests https://ci.apache.org/projects/ofbiz/logs/
>>>>> I will check that and will add R15.12 soon in Buildbot
>>>>> I got the error in Windows w/ another one (service-xml-rpc-local-engine)
>>>>> so I checked in Linux and got only the
>>>>> testCreateOrderConfigurableServiceProduct error
>>>>> I did not check details but I guess the same appears in R14.12:
>>>>> https://ci.apache.org/builders/ofbiz-branch14
>>>>>
>>>> And of course R15.12
>>>>
>>>>
>>>>
>>>>> Jacques
>>>>>
>>>>> Le 16/01/2016 11:58, deepak@apache.org a écrit :
>>>>>
>>>>>> Author: deepak
>>>>>> Date: Sat Jan 16 10:58:26 2016
>>>>>> New Revision: 1724954
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
>>>>>> Log:
>>>>>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
>>>>>> ============================================================
>>>>>> Session already invalidate (removeAttribute: Session already
>>>>>> invalidated) on destroyCart for anonymous userLogin
>>>>>> ============================================================
>>>>>>
>>>>>> Thanks Ankush for your contribution.
>>>>>>
>>>>>> Modified:
>>>>>>
>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>> ---
>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>> (original)
>>>>>> +++
>>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>> Sat Jan 16 10:58:26 2016
>>>>>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
>>>>>> /** Totally wipe out the cart, removes all stored info. */
>>>>>> public static String destroyCart(HttpServletRequest request,
>>>>>> HttpServletResponse response) {
>>>>>> HttpSession session = request.getSession();
>>>>>> - clearCart(request, response);
>>>>>> session.removeAttribute("shoppingCart");
>>>>>> session.removeAttribute("orderPartyId");
>>>>>> session.removeAttribute("orderMode");
>>>>>> session.removeAttribute("productStoreId");
>>>>>> session.removeAttribute("CURRENT_CATALOG_ID");
>>>>>> + // Call clearCart at the end as if user is anonymous then it
>>>>>> will throw session already invalidated error on removeAttribute method.
>>>>>> + clearCart(request, response);
>>>>>> return "success";
>>>>>> }
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>
Re: svn commit: r1724954 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Sorry Deepak,
The weird things with tests is that
https://ci.apache.org/builders/ofbiz-trunk/builds/351
is OK but
https://ci.apache.org/builders/ofbiz-trunk/builds/352
is not
But actually I just spotted there were 2 changes in this build
https://ci.apache.org/builders/ofbiz-trunk/builds/352#changes-
I locally reverted r1724954 and tests passed, I will revert it on trunk now and will reopen OFBIZ-6805
It's maybe the right direction and the problem is in testCreateOrderConfigurableServiceProduct
Being buzzy on other stuff I did not get a chance to look further yet
Jacques
Le 18/01/2016 11:51, Deepak Dixit a écrit :
> Hi Jacques,
>
> I dig into it and found that its was not broken due to mentioned commit, I
> reverted it and still its broken.
> Its due to because initializeOrderEntry returns error as product store not
> found in request.
>
> {code}
>
> [java] 2016-01-18 16:14:03,129 |main
> |ProductStoreWorker |E| No product store found in request,
> cannot set locale!
>
> {code}
>
>
>
>
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
>
> On Mon, Jan 18, 2016 at 10:28 AM, Deepak Dixit <
> deepak.dixit@hotwaxsystems.com> wrote:
>
>> Thanks Jacques for reporting , Let me check.
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxsystems.com
>>
>> On Sun, Jan 17, 2016 at 4:38 AM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> Le 17/01/2016 00:07, Jacques Le Roux a écrit :
>>>
>>>> I did not dive into details but
>>>> testCreateOrderConfigurableServiceProduct reports an issue with this change.
>>>> It was not obvious to me initially because thought Buildbot stopped
>>>> there https://ci.apache.org/builders/ofbiz-trunk it did not report the
>>>> error in tests https://ci.apache.org/projects/ofbiz/logs/
>>>> I will check that and will add R15.12 soon in Buildbot
>>>> I got the error in Windows w/ another one (service-xml-rpc-local-engine)
>>>> so I checked in Linux and got only the
>>>> testCreateOrderConfigurableServiceProduct error
>>>> I did not check details but I guess the same appears in R14.12:
>>>> https://ci.apache.org/builders/ofbiz-branch14
>>>>
>>> And of course R15.12
>>>
>>>
>>>
>>>> Jacques
>>>>
>>>> Le 16/01/2016 11:58, deepak@apache.org a écrit :
>>>>
>>>>> Author: deepak
>>>>> Date: Sat Jan 16 10:58:26 2016
>>>>> New Revision: 1724954
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
>>>>> Log:
>>>>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
>>>>> ============================================================
>>>>> Session already invalidate (removeAttribute: Session already
>>>>> invalidated) on destroyCart for anonymous userLogin
>>>>> ============================================================
>>>>>
>>>>> Thanks Ankush for your contribution.
>>>>>
>>>>> Modified:
>>>>>
>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
>>>>>
>>>>> ==============================================================================
>>>>> ---
>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>> (original)
>>>>> +++
>>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>> Sat Jan 16 10:58:26 2016
>>>>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
>>>>> /** Totally wipe out the cart, removes all stored info. */
>>>>> public static String destroyCart(HttpServletRequest request,
>>>>> HttpServletResponse response) {
>>>>> HttpSession session = request.getSession();
>>>>> - clearCart(request, response);
>>>>> session.removeAttribute("shoppingCart");
>>>>> session.removeAttribute("orderPartyId");
>>>>> session.removeAttribute("orderMode");
>>>>> session.removeAttribute("productStoreId");
>>>>> session.removeAttribute("CURRENT_CATALOG_ID");
>>>>> + // Call clearCart at the end as if user is anonymous then it
>>>>> will throw session already invalidated error on removeAttribute method.
>>>>> + clearCart(request, response);
>>>>> return "success";
>>>>> }
>>>>>
>>>>>
>>>>>
>>>>>
Re: svn commit: r1724954 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Hi Jacques,
I dig into it and found that its was not broken due to mentioned commit, I
reverted it and still its broken.
Its due to because initializeOrderEntry returns error as product store not
found in request.
{code}
[java] 2016-01-18 16:14:03,129 |main
|ProductStoreWorker |E| No product store found in request,
cannot set locale!
{code}
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Mon, Jan 18, 2016 at 10:28 AM, Deepak Dixit <
deepak.dixit@hotwaxsystems.com> wrote:
> Thanks Jacques for reporting , Let me check.
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
>
> On Sun, Jan 17, 2016 at 4:38 AM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Le 17/01/2016 00:07, Jacques Le Roux a écrit :
>>
>>> I did not dive into details but
>>> testCreateOrderConfigurableServiceProduct reports an issue with this change.
>>> It was not obvious to me initially because thought Buildbot stopped
>>> there https://ci.apache.org/builders/ofbiz-trunk it did not report the
>>> error in tests https://ci.apache.org/projects/ofbiz/logs/
>>> I will check that and will add R15.12 soon in Buildbot
>>> I got the error in Windows w/ another one (service-xml-rpc-local-engine)
>>> so I checked in Linux and got only the
>>> testCreateOrderConfigurableServiceProduct error
>>> I did not check details but I guess the same appears in R14.12:
>>> https://ci.apache.org/builders/ofbiz-branch14
>>>
>>
>> And of course R15.12
>>
>>
>>
>>> Jacques
>>>
>>> Le 16/01/2016 11:58, deepak@apache.org a écrit :
>>>
>>>> Author: deepak
>>>> Date: Sat Jan 16 10:58:26 2016
>>>> New Revision: 1724954
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
>>>> Log:
>>>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
>>>> ============================================================
>>>> Session already invalidate (removeAttribute: Session already
>>>> invalidated) on destroyCart for anonymous userLogin
>>>> ============================================================
>>>>
>>>> Thanks Ankush for your contribution.
>>>>
>>>> Modified:
>>>>
>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
>>>>
>>>> ==============================================================================
>>>> ---
>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>> (original)
>>>> +++
>>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>> Sat Jan 16 10:58:26 2016
>>>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
>>>> /** Totally wipe out the cart, removes all stored info. */
>>>> public static String destroyCart(HttpServletRequest request,
>>>> HttpServletResponse response) {
>>>> HttpSession session = request.getSession();
>>>> - clearCart(request, response);
>>>> session.removeAttribute("shoppingCart");
>>>> session.removeAttribute("orderPartyId");
>>>> session.removeAttribute("orderMode");
>>>> session.removeAttribute("productStoreId");
>>>> session.removeAttribute("CURRENT_CATALOG_ID");
>>>> + // Call clearCart at the end as if user is anonymous then it
>>>> will throw session already invalidated error on removeAttribute method.
>>>> + clearCart(request, response);
>>>> return "success";
>>>> }
>>>>
>>>>
>>>>
>>>>
>>>
>
Re: svn commit: r1724954 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Thanks Jacques for reporting , Let me check.
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Sun, Jan 17, 2016 at 4:38 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Le 17/01/2016 00:07, Jacques Le Roux a écrit :
>
>> I did not dive into details but testCreateOrderConfigurableServiceProduct
>> reports an issue with this change.
>> It was not obvious to me initially because thought Buildbot stopped there
>> https://ci.apache.org/builders/ofbiz-trunk it did not report the error
>> in tests https://ci.apache.org/projects/ofbiz/logs/
>> I will check that and will add R15.12 soon in Buildbot
>> I got the error in Windows w/ another one (service-xml-rpc-local-engine)
>> so I checked in Linux and got only the
>> testCreateOrderConfigurableServiceProduct error
>> I did not check details but I guess the same appears in R14.12:
>> https://ci.apache.org/builders/ofbiz-branch14
>>
>
> And of course R15.12
>
>
>
>> Jacques
>>
>> Le 16/01/2016 11:58, deepak@apache.org a écrit :
>>
>>> Author: deepak
>>> Date: Sat Jan 16 10:58:26 2016
>>> New Revision: 1724954
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
>>> Log:
>>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
>>> ============================================================
>>> Session already invalidate (removeAttribute: Session already
>>> invalidated) on destroyCart for anonymous userLogin
>>> ============================================================
>>>
>>> Thanks Ankush for your contribution.
>>>
>>> Modified:
>>>
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>
>>> Modified:
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>> Sat Jan 16 10:58:26 2016
>>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
>>> /** Totally wipe out the cart, removes all stored info. */
>>> public static String destroyCart(HttpServletRequest request,
>>> HttpServletResponse response) {
>>> HttpSession session = request.getSession();
>>> - clearCart(request, response);
>>> session.removeAttribute("shoppingCart");
>>> session.removeAttribute("orderPartyId");
>>> session.removeAttribute("orderMode");
>>> session.removeAttribute("productStoreId");
>>> session.removeAttribute("CURRENT_CATALOG_ID");
>>> + // Call clearCart at the end as if user is anonymous then it
>>> will throw session already invalidated error on removeAttribute method.
>>> + clearCart(request, response);
>>> return "success";
>>> }
>>>
>>>
>>>
>>>
>>
Re: svn commit: r1724954 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 17/01/2016 00:07, Jacques Le Roux a écrit :
> I did not dive into details but testCreateOrderConfigurableServiceProduct reports an issue with this change.
> It was not obvious to me initially because thought Buildbot stopped there https://ci.apache.org/builders/ofbiz-trunk it did not report the error in
> tests https://ci.apache.org/projects/ofbiz/logs/
> I will check that and will add R15.12 soon in Buildbot
> I got the error in Windows w/ another one (service-xml-rpc-local-engine) so I checked in Linux and got only the
> testCreateOrderConfigurableServiceProduct error
> I did not check details but I guess the same appears in R14.12: https://ci.apache.org/builders/ofbiz-branch14
And of course R15.12
>
> Jacques
>
> Le 16/01/2016 11:58, deepak@apache.org a écrit :
>> Author: deepak
>> Date: Sat Jan 16 10:58:26 2016
>> New Revision: 1724954
>>
>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
>> Log:
>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
>> ============================================================
>> Session already invalidate (removeAttribute: Session already invalidated) on destroyCart for anonymous userLogin
>> ============================================================
>>
>> Thanks Ankush for your contribution.
>>
>> Modified:
>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>
>> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java (original)
>> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java Sat Jan 16 10:58:26 2016
>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
>> /** Totally wipe out the cart, removes all stored info. */
>> public static String destroyCart(HttpServletRequest request, HttpServletResponse response) {
>> HttpSession session = request.getSession();
>> - clearCart(request, response);
>> session.removeAttribute("shoppingCart");
>> session.removeAttribute("orderPartyId");
>> session.removeAttribute("orderMode");
>> session.removeAttribute("productStoreId");
>> session.removeAttribute("CURRENT_CATALOG_ID");
>> + // Call clearCart at the end as if user is anonymous then it will throw session already invalidated error on removeAttribute method.
>> + clearCart(request, response);
>> return "success";
>> }
>>
>>
>>
>
Re: svn commit: r1724954 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCa
rtEvents.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
I did not dive into details but testCreateOrderConfigurableServiceProduct reports an issue with this change.
It was not obvious to me initially because thought Buildbot stopped there https://ci.apache.org/builders/ofbiz-trunk it did not report the error in
tests https://ci.apache.org/projects/ofbiz/logs/
I will check that and will add R15.12 soon in Buildbot
I got the error in Windows w/ another one (service-xml-rpc-local-engine) so I checked in Linux and got only the
testCreateOrderConfigurableServiceProduct error
I did not check details but I guess the same appears in R14.12: https://ci.apache.org/builders/ofbiz-branch14
Jacques
Le 16/01/2016 11:58, deepak@apache.org a écrit :
> Author: deepak
> Date: Sat Jan 16 10:58:26 2016
> New Revision: 1724954
>
> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev
> Log:
> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805
> ============================================================
> Session already invalidate (removeAttribute: Session already invalidated) on destroyCart for anonymous userLogin
> ============================================================
>
> Thanks Ankush for your contribution.
>
> Modified:
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>
> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java (original)
> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java Sat Jan 16 10:58:26 2016
> @@ -937,12 +937,13 @@ public class ShoppingCartEvents {
> /** Totally wipe out the cart, removes all stored info. */
> public static String destroyCart(HttpServletRequest request, HttpServletResponse response) {
> HttpSession session = request.getSession();
> - clearCart(request, response);
> session.removeAttribute("shoppingCart");
> session.removeAttribute("orderPartyId");
> session.removeAttribute("orderMode");
> session.removeAttribute("productStoreId");
> session.removeAttribute("CURRENT_CATALOG_ID");
> + // Call clearCart at the end as if user is anonymous then it will throw session already invalidated error on removeAttribute method.
> + clearCart(request, response);
> return "success";
> }
>
>
>
>