You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/27 21:23:03 UTC
[GitHub] [airflow] davidcaron opened a new pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
davidcaron opened a new pull request #18707:
URL: https://github.com/apache/airflow/pull/18707
When execution_date is `None`, the generated name for the `run_id` contains the a generated `execution_date` in isoformat.
That `execution_date`should be passed to `trigger_dag`, otherwise we have a mismatch between the `execution_date` in `run_id` and the actual `execution_date` of the dag run.
This didn't cause any issues per se, but I thought it should be fixed for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-1011990317
I merged main and removed the full-test-needed label, this should help us see where test failures are from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-1023651349
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-975069991
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-1027363254
I just merged main and the mssql failures are also happening in main. Still, I'm going to wait on merging this just to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-1027629218
Hmm, looks like MSSQL has some issues with datetime values added in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-995456560
tests seem to fail :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-1029526229
Looks good now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #18707:
URL: https://github.com/apache/airflow/pull/18707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-975069346
I added a couple of checks to existing tests to ensure the run ID is generated consistently. I also expanded the refactoring a little to strighten up the type of `self.execution_date`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18707:
URL: https://github.com/apache/airflow/pull/18707#issuecomment-973498520
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #18707: Fix mismatch in generated run_id and logical date of DAG run
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #18707:
URL: https://github.com/apache/airflow/pull/18707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org