You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2016/11/02 14:15:03 UTC
[VOTE] Release Apache Tomcat 8.5.7
The proposed Apache Tomcat 8.5.7 release is now available for voting.
The major changes compared to the 8.5.6 release are:
- Implement header limits for HTTP/2
- Improve handling of I/O errors with async processing
- Fail earlier on invalid HTTP requests
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1102/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
The proposed 8.5.7 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 8.5.7
[ ] Beta - go ahead and release as 8.5.7
[ ] Stable - go ahead and release as 8.5.7
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 11/2/16 10:15 AM, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>
> The major changes compared to the 8.5.6 release are:
>
>
> - Implement header limits for HTTP/2
>
> - Improve handling of I/O errors with async processing
>
> - Fail earlier on invalid HTTP requests
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>
> The proposed 8.5.7 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 8.5.7
> [ ] Beta - go ahead and release as 8.5.7
Do we still need Alpha and Beta choices for 8.5.x? At this point, it
should either be Broken or Stable, no?
> [X] Stable - go ahead and release as 8.5.7
Works fine for a non-fancy web application (no websocket, h2, etc.). See
below for some potentially bad test failures... I'm not sure I know what
reasonable things could have caused them.
Details:
* Environment
* Java (build): java version "1.8.0_101" Java(TM) SE Runtime
Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM
(build 25.101-b13, mixed mode)
* Java (test): java version "1.8.0_101" Java(TM) SE Runtime
Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM
(build 25.101-b13, mixed mode)
* OS: Linux 2.6.32-312-ec2 x86_64
* cc: cc (Debian 4.7.2-5) 4.7.2
* make: GNU Make 3.81
* OpenSSL: OpenSSL 1.0.2f 28 Jan 2016 (Library: OpenSSL 1.0.1t 3 May 2016)
* APR: 1.4.6
*
* Valid MD5 signature for apache-tomcat-8.5.7.zip
* Valid GPG signature for apache-tomcat-8.5.7.zip
* Valid MD5 signature for apache-tomcat-8.5.7.tar.gz
* Valid GPG signature for apache-tomcat-8.5.7.tar.gz
* Valid MD5 signature for apache-tomcat-8.5.7.exe
* Valid GPG signature for apache-tomcat-8.5.7.exe
* Valid MD5 signature for apache-tomcat-8.5.7-src.zip
* Valid GPG signature for apache-tomcat-8.5.7-src.zip
* Valid MD5 signature for apache-tomcat-8.5.7-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.7-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.catalina.session.TestStandardSessionIntegration.APR.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
The above tests are expected to fail in my environment.
I'm not so sure about those below:
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
These failures are likely due to imperfect OpenSSL version matching
(note the mismatched build vs "library" versions of OpenSSL).
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Mark Thomas <ma...@apache.org>.
This vote is cancelled due to a regression in the fix for BZ 60319.
8.5.8 will follow shortly.
Mark
On 02/11/2016 14:15, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>
> The major changes compared to the 8.5.6 release are:
>
>
> - Implement header limits for HTTP/2
>
> - Improve handling of I/O errors with async processing
>
> - Fail earlier on invalid HTTP requests
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>
> The proposed 8.5.7 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 8.5.7
> [ ] Beta - go ahead and release as 8.5.7
> [ ] Stable - go ahead and release as 8.5.7
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 03.11.2016 um 18:32 schrieb Christopher Schultz:
> Felix,
>
> On 11/3/16 10:43 AM, Felix Schumacher wrote:
>> Hi all,
>>
>> change r1767357 broke ajp connector with an executor.
>>
>> Tomcat fails to set the thread priority, since the ajp connector
>> reports a default priority of -1 and Thread#setPriority will throw an
>> IAE in line 583 of AbstractProtocol#start.
>>
>> To reproduce this enable the commented executor in server.xml and add
>> that executor to the ajp connector.
> I'm using this configuration with 8.5 with no ill effects:
>
> <Executor name="tomcatThreadPool" namePrefix="catalina-exec-"
> maxThreads="150" minSpareThreads="4"/>
>
> <Connector port="@connector-port@"
> redirectPort="443"
> protocol="org.apache.coyote.ajp.AjpNioProtocol"
> URIEncoding="UTF-8"
> packetSize="65536"
> executor="tomcatThreadPool" />
>
> <Connector port="@secure-connector-port@"
> protocol="org.apache.coyote.http11.Http11NioProtocol"
> address="127.0.0.1"
> secure="false"
> URIEncoding="UTF-8"
> executor="tomcatThreadPool" />
>
> Which exact connector are you using? How do I need to change my
> configuration to confirm the problem?
I used the conf/server.xml from output/build. In fact I changed into
output/build and edited conf/server.xml with
--- conf/server.xml.orig 2016-11-03 18:43:48.737312712 +0100
+++ conf/server.xml 2016-11-03 18:44:29.069284390 +0100
@@ -53,10 +53,8 @@
<Service name="Catalina">
<!--The connectors can use a shared executor, you can define one
or more named thread pools-->
- <!--
<Executor name="tomcatThreadPool" namePrefix="catalina-exec-"
maxThreads="150" minSpareThreads="4"/>
- -->
<!-- A "Connector" represents an endpoint by which requests are
received
@@ -108,7 +106,7 @@
-->
<!-- Define an AJP 1.3 Connector on port 8009 -->
- <Connector port="8009" protocol="AJP/1.3" redirectPort="8443" />
+ <Connector port="8009" protocol="AJP/1.3" redirectPort="8443"
executor="tomcatThreadPool" />
<!-- An Engine represents the entry point (within Catalina) that
processes
and started tomcat with ./bin/startup.sh
Regards,
Felix
>
>> A second rather minor point is a white space policy violation in
>> webapps/docs/config/http2.xml:160.
> Oh noes! :)
>
> -chris
>
>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <ma...@apache.org>:
>>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.6 release are:
>>>
>>>
>>> - Implement header limits for HTTP/2
>>>
>>> - Improve handling of I/O errors with async processing
>>>
>>> - Fail earlier on invalid HTTP requests
>>>
>>> It can be obtained from:
>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>> The Maven staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>> The svn tag is:
>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>
>>> The proposed 8.5.7 release is:
>>> [ ] Broken - do not release
>>> [ ] Alpha - go ahead and release as 8.5.7
>>> [ ] Beta - go ahead and release as 8.5.7
>>> [ ] Stable - go ahead and release as 8.5.7
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Felix,
On 11/3/16 10:43 AM, Felix Schumacher wrote:
> Hi all,
>
> change r1767357 broke ajp connector with an executor.
>
> Tomcat fails to set the thread priority, since the ajp connector
> reports a default priority of -1 and Thread#setPriority will throw an
> IAE in line 583 of AbstractProtocol#start.
>
> To reproduce this enable the commented executor in server.xml and add
> that executor to the ajp connector.
I'm using this configuration with 8.5 with no ill effects:
<Executor name="tomcatThreadPool" namePrefix="catalina-exec-"
maxThreads="150" minSpareThreads="4"/>
<Connector port="@connector-port@"
redirectPort="443"
protocol="org.apache.coyote.ajp.AjpNioProtocol"
URIEncoding="UTF-8"
packetSize="65536"
executor="tomcatThreadPool" />
<Connector port="@secure-connector-port@"
protocol="org.apache.coyote.http11.Http11NioProtocol"
address="127.0.0.1"
secure="false"
URIEncoding="UTF-8"
executor="tomcatThreadPool" />
Which exact connector are you using? How do I need to change my
configuration to confirm the problem?
> A second rather minor point is a white space policy violation in
> webapps/docs/config/http2.xml:160.
Oh noes! :)
-chris
> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <ma...@apache.org>:
>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>
>> The major changes compared to the 8.5.6 release are:
>>
>>
>> - Implement header limits for HTTP/2
>>
>> - Improve handling of I/O errors with async processing
>>
>> - Fail earlier on invalid HTTP requests
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>
>> The proposed 8.5.7 release is:
>> [ ] Broken - do not release
>> [ ] Alpha - go ahead and release as 8.5.7
>> [ ] Beta - go ahead and release as 8.5.7
>> [ ] Stable - go ahead and release as 8.5.7
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Rémy Maucherat <re...@apache.org>.
2016-11-03 15:49 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 03/11/2016 14:43, Felix Schumacher wrote:
> > Hi all,
> >
> > change r1767357 broke ajp connector with an executor.
> >
> > Tomcat fails to set the thread priority, since the ajp connector reports
> a default priority of -1 and Thread#setPriority will throw an IAE in line
> 583 of AbstractProtocol#start.
> >
> > To reproduce this enable the commented executor in server.xml and add
> that executor to the ajp connector.
> >
> > A second rather minor point is a white space policy violation in
> webapps/docs/config/http2.xml:160.
>
> That almost certainly means 9.0.x is broken as well.
>
> I can re-roll once this is fixed.
>
> I'll be able to get to this in a few hours. If someone beats me to the
> fix, that would be great :)
>
> Bad luck ... AbstractProtocol.start should use Thread.NORM_PRIORITY if
getThreadPriority() is -1. I won't commit it since you'll have a lot of
tagging to do, so it won't make any difference :(
Rémy
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Coty Sutherland <cs...@redhat.com>.
Just a quick question for clarity regarding APR tests...we're testing
against the openssl-1.0.2-stable branch, correct? That passes fine,
but testing against trunk fails a couple of tests:
org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testAllOpenSSLCiphersMapped
junit.framework.AssertionFailedError: No mapping found in IBM's JSSE
implementation for TLS13-AES-128-GCM-SHA256+TLSv1.3 when one was
expected
No mapping found in Oracle's JSSE implementation for
TLS13-AES-128-GCM-SHA256+TLSv1.3 when one was expected
org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability
junit.framework.AssertionFailedError: TLS13-AES-128-GCM-SHA256+TLSv1.3
expected:<0> but was:<1>
at org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability(TestCipher.java:107)
On Thu, Nov 3, 2016 at 10:49 AM, Mark Thomas <ma...@apache.org> wrote:
> On 03/11/2016 14:43, Felix Schumacher wrote:
>> Hi all,
>>
>> change r1767357 broke ajp connector with an executor.
>>
>> Tomcat fails to set the thread priority, since the ajp connector reports a default priority of -1 and Thread#setPriority will throw an IAE in line 583 of AbstractProtocol#start.
>>
>> To reproduce this enable the commented executor in server.xml and add that executor to the ajp connector.
>>
>> A second rather minor point is a white space policy violation in webapps/docs/config/http2.xml:160.
>
> That almost certainly means 9.0.x is broken as well.
>
> I can re-roll once this is fixed.
>
> I'll be able to get to this in a few hours. If someone beats me to the
> fix, that would be great :)
>
> Mark
>
>>
>> Regards,
>> Felix
>>
>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <ma...@apache.org>:
>>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.6 release are:
>>>
>>>
>>> - Implement header limits for HTTP/2
>>>
>>> - Improve handling of I/O errors with async processing
>>>
>>> - Fail earlier on invalid HTTP requests
>>>
>>> It can be obtained from:
>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>> The Maven staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>> The svn tag is:
>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>
>>> The proposed 8.5.7 release is:
>>> [ ] Broken - do not release
>>> [ ] Alpha - go ahead and release as 8.5.7
>>> [ ] Beta - go ahead and release as 8.5.7
>>> [ ] Stable - go ahead and release as 8.5.7
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 3. November 2016 21:01:51 MEZ, schrieb Violeta Georgieva <mi...@gmail.com>:
>Hi Felix,
>
>2016-11-03 20:24 GMT+02:00 Felix Schumacher <
>felix.schumacher@internetallee.de>:
>>
>> Am 03.11.2016 um 15:49 schrieb Mark Thomas:
>>>
>>> On 03/11/2016 14:43, Felix Schumacher wrote:
>>>>
>>>> Hi all,
>>>>
>>>> change r1767357 broke ajp connector with an executor.
>>>>
>>>> Tomcat fails to set the thread priority, since the ajp connector
>reports a default priority of -1 and Thread#setPriority will throw an
>IAE
>in line 583 of AbstractProtocol#start.
>>>>
>>>> To reproduce this enable the commented executor in server.xml and
>add
>that executor to the ajp connector.
>>>>
>>>> A second rather minor point is a white space policy violation in
>webapps/docs/config/http2.xml:160.
>>>
>>> That almost certainly means 9.0.x is broken as well.
>>>
>>> I can re-roll once this is fixed.
>>>
>>> I'll be able to get to this in a few hours. If someone beats me to
>the
>>> fix, that would be great :)
>>
>> I have committed a fix for 9.0.0.M12 (which is affected as well - as
>you
>suspected).
>
>Do we need this fix in Tomcat 6/7/8.0?
I have had a short look at AbstractProtocol in tomcat 8.0 and couldn't find any reference to Thread#setPriority. So I think anything below 8.5 is safe.
A test with modified server.xml worked correctly.
Regards,
Felix
>
>Thanks,
>Violeta
>
>> Felix
>>
>>>
>>> Mark
>>>
>>>> Regards,
>>>> Felix
>>>>
>>>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas
><markt@apache.org
>>:
>>>>>
>>>>> The proposed Apache Tomcat 8.5.7 release is now available for
>voting.
>>>>>
>>>>> The major changes compared to the 8.5.6 release are:
>>>>>
>>>>>
>>>>> - Implement header limits for HTTP/2
>>>>>
>>>>> - Improve handling of I/O errors with async processing
>>>>>
>>>>> - Fail earlier on invalid HTTP requests
>>>>>
>>>>> It can be obtained from:
>>>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>>>> The Maven staging repo is:
>>>>>
>https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>>>> The svn tag is:
>>>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>>>
>>>>> The proposed 8.5.7 release is:
>>>>> [ ] Broken - do not release
>>>>> [ ] Alpha - go ahead and release as 8.5.7
>>>>> [ ] Beta - go ahead and release as 8.5.7
>>>>> [ ] Stable - go ahead and release as 8.5.7
>>>>>
>>>>>
>---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Violeta Georgieva <mi...@gmail.com>.
Hi Felix,
2016-11-03 20:24 GMT+02:00 Felix Schumacher <
felix.schumacher@internetallee.de>:
>
> Am 03.11.2016 um 15:49 schrieb Mark Thomas:
>>
>> On 03/11/2016 14:43, Felix Schumacher wrote:
>>>
>>> Hi all,
>>>
>>> change r1767357 broke ajp connector with an executor.
>>>
>>> Tomcat fails to set the thread priority, since the ajp connector
reports a default priority of -1 and Thread#setPriority will throw an IAE
in line 583 of AbstractProtocol#start.
>>>
>>> To reproduce this enable the commented executor in server.xml and add
that executor to the ajp connector.
>>>
>>> A second rather minor point is a white space policy violation in
webapps/docs/config/http2.xml:160.
>>
>> That almost certainly means 9.0.x is broken as well.
>>
>> I can re-roll once this is fixed.
>>
>> I'll be able to get to this in a few hours. If someone beats me to the
>> fix, that would be great :)
>
> I have committed a fix for 9.0.0.M12 (which is affected as well - as you
suspected).
Do we need this fix in Tomcat 6/7/8.0?
Thanks,
Violeta
> Felix
>
>>
>> Mark
>>
>>> Regards,
>>> Felix
>>>
>>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <markt@apache.org
>:
>>>>
>>>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>>>
>>>> The major changes compared to the 8.5.6 release are:
>>>>
>>>>
>>>> - Implement header limits for HTTP/2
>>>>
>>>> - Improve handling of I/O errors with async processing
>>>>
>>>> - Fail earlier on invalid HTTP requests
>>>>
>>>> It can be obtained from:
>>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>>> The Maven staging repo is:
>>>>
https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>>> The svn tag is:
>>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>>
>>>> The proposed 8.5.7 release is:
>>>> [ ] Broken - do not release
>>>> [ ] Alpha - go ahead and release as 8.5.7
>>>> [ ] Beta - go ahead and release as 8.5.7
>>>> [ ] Stable - go ahead and release as 8.5.7
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 03.11.2016 um 15:49 schrieb Mark Thomas:
> On 03/11/2016 14:43, Felix Schumacher wrote:
>> Hi all,
>>
>> change r1767357 broke ajp connector with an executor.
>>
>> Tomcat fails to set the thread priority, since the ajp connector reports a default priority of -1 and Thread#setPriority will throw an IAE in line 583 of AbstractProtocol#start.
>>
>> To reproduce this enable the commented executor in server.xml and add that executor to the ajp connector.
>>
>> A second rather minor point is a white space policy violation in webapps/docs/config/http2.xml:160.
> That almost certainly means 9.0.x is broken as well.
>
> I can re-roll once this is fixed.
>
> I'll be able to get to this in a few hours. If someone beats me to the
> fix, that would be great :)
I have committed a fix for 9.0.0.M12 (which is affected as well - as you
suspected).
Felix
>
> Mark
>
>> Regards,
>> Felix
>>
>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <ma...@apache.org>:
>>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.6 release are:
>>>
>>>
>>> - Implement header limits for HTTP/2
>>>
>>> - Improve handling of I/O errors with async processing
>>>
>>> - Fail earlier on invalid HTTP requests
>>>
>>> It can be obtained from:
>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>> The Maven staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>> The svn tag is:
>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>
>>> The proposed 8.5.7 release is:
>>> [ ] Broken - do not release
>>> [ ] Alpha - go ahead and release as 8.5.7
>>> [ ] Beta - go ahead and release as 8.5.7
>>> [ ] Stable - go ahead and release as 8.5.7
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Mark Thomas <ma...@apache.org>.
On 03/11/2016 14:43, Felix Schumacher wrote:
> Hi all,
>
> change r1767357 broke ajp connector with an executor.
>
> Tomcat fails to set the thread priority, since the ajp connector reports a default priority of -1 and Thread#setPriority will throw an IAE in line 583 of AbstractProtocol#start.
>
> To reproduce this enable the commented executor in server.xml and add that executor to the ajp connector.
>
> A second rather minor point is a white space policy violation in webapps/docs/config/http2.xml:160.
That almost certainly means 9.0.x is broken as well.
I can re-roll once this is fixed.
I'll be able to get to this in a few hours. If someone beats me to the
fix, that would be great :)
Mark
>
> Regards,
> Felix
>
> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <ma...@apache.org>:
>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>
>> The major changes compared to the 8.5.6 release are:
>>
>>
>> - Implement header limits for HTTP/2
>>
>> - Improve handling of I/O errors with async processing
>>
>> - Fail earlier on invalid HTTP requests
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>
>> The proposed 8.5.7 release is:
>> [ ] Broken - do not release
>> [ ] Alpha - go ahead and release as 8.5.7
>> [ ] Beta - go ahead and release as 8.5.7
>> [ ] Stable - go ahead and release as 8.5.7
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.7
Posted by Felix Schumacher <fe...@internetallee.de>.
Hi all,
change r1767357 broke ajp connector with an executor.
Tomcat fails to set the thread priority, since the ajp connector reports a default priority of -1 and Thread#setPriority will throw an IAE in line 583 of AbstractProtocol#start.
To reproduce this enable the commented executor in server.xml and add that executor to the ajp connector.
A second rather minor point is a white space policy violation in webapps/docs/config/http2.xml:160.
Regards,
Felix
Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas <ma...@apache.org>:
>The proposed Apache Tomcat 8.5.7 release is now available for voting.
>
>The major changes compared to the 8.5.6 release are:
>
>
>- Implement header limits for HTTP/2
>
>- Improve handling of I/O errors with async processing
>
>- Fail earlier on invalid HTTP requests
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>
>The proposed 8.5.7 release is:
>[ ] Broken - do not release
>[ ] Alpha - go ahead and release as 8.5.7
>[ ] Beta - go ahead and release as 8.5.7
>[ ] Stable - go ahead and release as 8.5.7
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>For additional commands, e-mail: dev-help@tomcat.apache.org