You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by pavel-kuznetsov <gi...@git.apache.org> on 2018/10/09 16:47:43 UTC

[GitHub] ignite pull request #4937: Ignite 9606 normalize refactoring

GitHub user pavel-kuznetsov opened a pull request:

    https://github.com/apache/ignite/pull/4937

    Ignite 9606 normalize refactoring

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-9606-normalize-refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4937
    
----
commit 5d144b2f57933b96dc4ccb68be119f7c205bb6f7
Author: Pavel Kuznetsov <pa...@...>
Date:   2018-10-02T14:43:31Z

    ignite-9606: Added test that reproduces the bug.

commit 0bf7d1c8265e681cdc5ea8b7d27c013844724be6
Author: Pavel Kuznetsov <pa...@...>
Date:   2018-10-03T13:02:42Z

    ignite-9606: fixed COLUMN_NAME metadata result.
    
    Earlier, if key was of SQL type (so not wrapped), corresponding property thought that it is not a key. This behaviour affected what COLUMN_NAME JDBC metadata would contain.

commit d350c5f3ab45849f608b6bab2335d33a84f78078
Author: Pavel Kuznetsov <pa...@...>
Date:   2018-10-05T19:56:27Z

    ignite-9606: Workaround for validation.
    
    prop.name() used to return UPPERCASED name of the field. So comparison with keyFieldName/valueFieldName (which are not uppercased) was incorrect. Probably, this validation logic should be revisited.

commit c81622e804fe9ecd6e25d697d46ca9e063e774d7
Author: Pavel Kuznetsov <pa...@...>
Date:   2018-10-09T15:22:16Z

    Revert "ignite-9606: Workaround for validation."
    
    This reverts commit d350c5f3ab45849f608b6bab2335d33a84f78078.

commit 6a10c7fdf7ab8e4bba31399a93864bf931a08c70
Author: Pavel Kuznetsov <pa...@...>
Date:   2018-10-09T15:24:09Z

    ignite-9606-normalize-refactoring: uppercase all fields.
    
    Now all the fields are uppercased during normalization.

----


---

[GitHub] ignite pull request #4937: Ignite 9606 normalize refactoring

Posted by pavel-kuznetsov <gi...@git.apache.org>.

Github user pavel-kuznetsov closed the pull request at:

    https://github.com/apache/ignite/pull/4937


---