You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Niels Basjes <Ni...@basjes.nl> on 2023/03/08 22:09:59 UTC
Does thrift need Java 11?
Hi,
I'm one of the PMCs of Apache Avro.
Dependabot created a merge request to update your library at our end
https://github.com/apache/avro/pull/2124
This failed because apparently this newer thrift version needs Java 11.
We see this message just prior to our build failing
*[INFO] Restricted to JDK 8 yet
org.apache.thrift:libthrift:jar:0.18.1:compile contains
org/apache/thrift/TBaseProcessor.class targeted to JDK 11*
I recognise the need for building under Java 11 or even Java 17 because
more and more maven/gradle plugins need this.
We have the same problem.
My question is does the binary release of thrift also need java 11 ?
Or can you tweak your build to produce Java 8 compatible binaries ?
--
Best regards / Met vriendelijke groeten,
Niels Basjes
Re: Does thrift need Java 11?
Posted by Niels Basjes <Ni...@basjes.nl>.
Hi,
Thanks for the info.
Niels Basjes
On Thu, Mar 9, 2023 at 4:02 AM Jiayu Liu <ji...@hey.com.invalid> wrote:
> Hi Niels,
>
> Yes we moved on to Java 11 last year and configured the build to be
> targeting Java 11 minimal (using gradle release config, the building JDK
> is 17 but the target release is 11), you can find more info here:
>
> https://github.com/apache/thrift/blob/master/lib/java/gradle/sourceConfiguration.gradle#L43
> .
>
> On March 9, 2023, Niels Basjes <ni...@basjes.nl> wrote:
> > Hi,
> >
> > I'm one of the PMCs of Apache Avro.
> > Dependabot created a merge request to update your library at our end
> > https://github.com/apache/avro/pull/2124
> >
> > This failed because apparently this newer thrift version needs Java
> > 11.
> > We see this message just prior to our build failing
> > *[INFO] Restricted to JDK 8 yet
> > org.apache.thrift:libthrift:jar:0.18.1:compile contains
> > org/apache/thrift/TBaseProcessor.class targeted to JDK 11*
> >
> > I recognise the need for building under Java 11 or even Java 17
> > because
> > more and more maven/gradle plugins need this.
> > We have the same problem.
> > My question is does the binary release of thrift also need java 11 ?
> > Or can you tweak your build to produce Java 8 compatible binaries ?
> >
> > --
> > Best regards / Met vriendelijke groeten,
> >
> > Niels Basjes
>
--
Best regards / Met vriendelijke groeten,
Niels Basjes
Re: Does thrift need Java 11?
Posted by Niels Basjes <Ni...@basjes.nl>.
Hi,
Thanks for the info.
Niels Basjes
On Thu, Mar 9, 2023 at 4:02 AM Jiayu Liu <ji...@hey.com.invalid> wrote:
> Hi Niels,
>
> Yes we moved on to Java 11 last year and configured the build to be
> targeting Java 11 minimal (using gradle release config, the building JDK
> is 17 but the target release is 11), you can find more info here:
>
> https://github.com/apache/thrift/blob/master/lib/java/gradle/sourceConfiguration.gradle#L43
> .
>
> On March 9, 2023, Niels Basjes <ni...@basjes.nl> wrote:
> > Hi,
> >
> > I'm one of the PMCs of Apache Avro.
> > Dependabot created a merge request to update your library at our end
> > https://github.com/apache/avro/pull/2124
> >
> > This failed because apparently this newer thrift version needs Java
> > 11.
> > We see this message just prior to our build failing
> > *[INFO] Restricted to JDK 8 yet
> > org.apache.thrift:libthrift:jar:0.18.1:compile contains
> > org/apache/thrift/TBaseProcessor.class targeted to JDK 11*
> >
> > I recognise the need for building under Java 11 or even Java 17
> > because
> > more and more maven/gradle plugins need this.
> > We have the same problem.
> > My question is does the binary release of thrift also need java 11 ?
> > Or can you tweak your build to produce Java 8 compatible binaries ?
> >
> > --
> > Best regards / Met vriendelijke groeten,
> >
> > Niels Basjes
>
--
Best regards / Met vriendelijke groeten,
Niels Basjes
Re: Does thrift need Java 11?
Posted by Jiayu Liu <ji...@hey.com.INVALID>.
Hi Niels,
Yes we moved on to Java 11 last year and configured the build to be
targeting Java 11 minimal (using gradle release config, the building JDK
is 17 but the target release is 11), you can find more info here:
https://github.com/apache/thrift/blob/master/lib/java/gradle/sourceConfiguration.gradle#L43.
On March 9, 2023, Niels Basjes <ni...@basjes.nl> wrote:
> Hi,
>
> I'm one of the PMCs of Apache Avro.
> Dependabot created a merge request to update your library at our end
> https://github.com/apache/avro/pull/2124
>
> This failed because apparently this newer thrift version needs Java
> 11.
> We see this message just prior to our build failing
> *[INFO] Restricted to JDK 8 yet
> org.apache.thrift:libthrift:jar:0.18.1:compile contains
> org/apache/thrift/TBaseProcessor.class targeted to JDK 11*
>
> I recognise the need for building under Java 11 or even Java 17
> because
> more and more maven/gradle plugins need this.
> We have the same problem.
> My question is does the binary release of thrift also need java 11 ?
> Or can you tweak your build to produce Java 8 compatible binaries ?
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes
Re: Does thrift need Java 11?
Posted by Jiayu Liu <ji...@hey.com.INVALID>.
Hi Niels,
Yes we moved on to Java 11 last year and configured the build to be
targeting Java 11 minimal (using gradle release config, the building JDK
is 17 but the target release is 11), you can find more info here:
https://github.com/apache/thrift/blob/master/lib/java/gradle/sourceConfiguration.gradle#L43.
On March 9, 2023, Niels Basjes <ni...@basjes.nl> wrote:
> Hi,
>
> I'm one of the PMCs of Apache Avro.
> Dependabot created a merge request to update your library at our end
> https://github.com/apache/avro/pull/2124
>
> This failed because apparently this newer thrift version needs Java
> 11.
> We see this message just prior to our build failing
> *[INFO] Restricted to JDK 8 yet
> org.apache.thrift:libthrift:jar:0.18.1:compile contains
> org/apache/thrift/TBaseProcessor.class targeted to JDK 11*
>
> I recognise the need for building under Java 11 or even Java 17
> because
> more and more maven/gradle plugins need this.
> We have the same problem.
> My question is does the binary release of thrift also need java 11 ?
> Or can you tweak your build to produce Java 8 compatible binaries ?
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes