You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/05/17 01:51:48 UTC
[GitHub] [hadoop] mukul1987 commented on a change in pull request #799:
HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock
protected.
mukul1987 commented on a change in pull request #799: HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected.
URL: https://github.com/apache/hadoop/pull/799#discussion_r284954692
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
##########
@@ -182,18 +182,28 @@ public AllocatedBlock allocateBlock(final long size, ReplicationType type,
pipelineManager
.getPipelines(type, factor, Pipeline.PipelineState.OPEN,
excludeList.getDatanodes(), excludeList.getPipelineIds());
- Pipeline pipeline;
+ Pipeline pipeline = null;
if (availablePipelines.size() == 0) {
try {
// TODO: #CLUTIL Remove creation logic when all replication types and
// factors are handled by pipeline creator
pipeline = pipelineManager.createPipeline(type, factor);
} catch (IOException e) {
- LOG.error("Pipeline creation failed for type:{} factor:{}",
+ LOG.warn("Pipeline creation failed for type:{} factor:{}",
type, factor, e);
- break;
+ LOG.info("Checking one more time for suitable pipelines");
+ availablePipelines = pipelineManager
+ .getPipelines(type, factor, Pipeline.PipelineState.OPEN,
+ excludeList.getDatanodes(), excludeList.getPipelineIds());
+ if (availablePipelines.size() == 0) {
+ LOG.info("Could not find available pipeline even after trying " +
Review comment:
Same as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org