You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/01/08 04:16:16 UTC
Review Request: FLUME-1823. LoadBalancingRpcClient method must throw
exception if it is called after close is called.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8874/
-----------------------------------------------------------
Review request for Flume.
Description
-------
A closed RpcClient will now throw if append is called after close
This addresses bug FLUME-1823.
https://issues.apache.org/jira/browse/FLUME-1823
Diffs
-----
flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java f396104
flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 9071734
Diff: https://reviews.apache.org/r/8874/diff/
Testing
-------
Added a unit test to verify the new feature. All current tests pass.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1823. LoadBalancingRpcClient method must throw
exception if it is called after close is called.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8874/
-----------------------------------------------------------
(Updated April 6, 2013, 3:16 a.m.)
Review request for Flume.
Description
-------
A closed RpcClient will now throw if append is called after close
This addresses bug FLUME-1823.
https://issues.apache.org/jira/browse/FLUME-1823
Diffs (updated)
-----
flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java f396104
flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 9071734
Diff: https://reviews.apache.org/r/8874/diff/
Testing
-------
Added a unit test to verify the new feature. All current tests pass.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1823. LoadBalancingRpcClient method must throw
exception if it is called after close is called.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8874/#review18747
-----------------------------------------------------------
flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java
<https://reviews.apache.org/r/8874/#comment39166>
This comment is nor correct any longer, correct?
- Brock Noland
On Jan. 8, 2013, 3:16 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8874/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 3:16 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> A closed RpcClient will now throw if append is called after close
>
>
> This addresses bug FLUME-1823.
> https://issues.apache.org/jira/browse/FLUME-1823
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java f396104
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 9071734
>
> Diff: https://reviews.apache.org/r/8874/diff/
>
>
> Testing
> -------
>
> Added a unit test to verify the new feature. All current tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>