You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by gn...@apache.org on 2014/11/27 08:59:45 UTC
[2/3] karaf git commit: [KARAF-3384] Commands are not unregistered
correctly
[KARAF-3384] Commands are not unregistered correctly
Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/2fe7bcbc
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/2fe7bcbc
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/2fe7bcbc
Branch: refs/heads/master
Commit: 2fe7bcbcb0e41b4c40dad48db4b48a0a4420e403
Parents: 72630a3
Author: Guillaume Nodet <gn...@gmail.com>
Authored: Fri Nov 21 10:06:23 2014 +0100
Committer: Guillaume Nodet <gn...@gmail.com>
Committed: Thu Nov 27 08:48:15 2014 +0100
----------------------------------------------------------------------
.../org/apache/karaf/shell/impl/action/command/ManagerImpl.java | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/karaf/blob/2fe7bcbc/shell/core/src/main/java/org/apache/karaf/shell/impl/action/command/ManagerImpl.java
----------------------------------------------------------------------
diff --git a/shell/core/src/main/java/org/apache/karaf/shell/impl/action/command/ManagerImpl.java b/shell/core/src/main/java/org/apache/karaf/shell/impl/action/command/ManagerImpl.java
index 6aa0d32..470b4f5 100644
--- a/shell/core/src/main/java/org/apache/karaf/shell/impl/action/command/ManagerImpl.java
+++ b/shell/core/src/main/java/org/apache/karaf/shell/impl/action/command/ManagerImpl.java
@@ -135,6 +135,9 @@ public class ManagerImpl implements Manager {
throw new IllegalArgumentException("Command " + clazz.getName() + " is not annotated with @Command");
}
Object command = new ActionCommand(this, (Class<? extends Action>) clazz);
+ synchronized (instances) {
+ instances.put(clazz, command);
+ }
registrations.register(command);
}
if (allowCustomServices || Completer.class.isAssignableFrom(clazz)) {