You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/07/11 03:58:23 UTC
[GitHub] [ratis] kaijchen opened a new pull request, #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
kaijchen opened a new pull request, #678:
URL: https://github.com/apache/ratis/pull/678
## What changes were proposed in this pull request?
dropwizard.metrics is incompatible between 3.x and 4.x.
And we should not upgrade it in Ratis 2.x branch.
This reverts commit dbb4ffa3b1cbabb48fb3c9cb5689b5ec60e857ee.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1620
## How was this patch tested?
https://github.com/kaijchen/ratis/actions/runs/2647060883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen commented on pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #678:
URL: https://github.com/apache/ratis/pull/678#issuecomment-1179938387
Cc @codings-dan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #678:
URL: https://github.com/apache/ratis/pull/678#issuecomment-1180120352
@kaijchen In fact, I am not very familiar with this part. In my opinion, in order to prevent conflicts with application dependencies that depend on ratis, we shaded the dependency paths related to dropwizard in ratis, which seems to have solved the problem in the mail. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen closed pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
URL: https://github.com/apache/ratis/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #678:
URL: https://github.com/apache/ratis/pull/678#issuecomment-1184648203
Yes, we are using the shaded dropwizard.metrics now; see https://issues.apache.org/jira/browse/RATIS-1601 .
Just have merged it and other changes to branch-2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen commented on pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #678:
URL: https://github.com/apache/ratis/pull/678#issuecomment-1180124266
OK, closing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen commented on pull request #678: RATIS-1620. Revert RATIS-1391 in branch 2.x
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #678:
URL: https://github.com/apache/ratis/pull/678#issuecomment-1180102921
Thanks for the explanation. I noticed this issue from the "Planning for 3.0.0" mail.
> 2.x.x have been around for more than a year. How about we start working on
3.0.0 so that we can have incompatible changes? One of the motivations is
to merge https://issues.apache.org/jira/browse/RATIS-1391 "Update library
dropwizard.metrics version to 4.x" since dropwizard.metrics is incompatible
between 3.x and 4.x.
Seems you've found a way to solve this issue, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org