You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by zs...@apache.org on 2009/02/05 00:56:51 UTC

svn commit: r740941 - in /hadoop/hive/trunk: CHANGES.txt common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java

Author: zshao
Date: Wed Feb  4 23:56:50 2009
New Revision: 740941

URL: http://svn.apache.org/viewvc?rev=740941&view=rev
Log:
HIVE-255. Propagate user name to Hive metastore. (Prasad Chakka via zshao)

Modified:
    hadoop/hive/trunk/CHANGES.txt
    hadoop/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
    hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java

Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=740941&r1=740940&r2=740941&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Wed Feb  4 23:56:50 2009
@@ -120,6 +120,8 @@
 
   BUG FIXES
 
+    HIVE-255. Propagate user name to Hive metastore. (Prasad Chakka via zshao)
+
     HIVE-263. TCTLSeparatedProtocol should use UTF-8 to encode/decode
     the data. (zshao)
 

Modified: hadoop/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java?rev=740941&r1=740940&r2=740941&view=diff
==============================================================================
--- hadoop/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (original)
+++ hadoop/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Wed Feb  4 23:56:50 2009
@@ -366,7 +366,11 @@
    */
   public String getUser() throws IOException {
     try {
-      return UserGroupInformation.login(this).getUserName();
+       UserGroupInformation ugi = UserGroupInformation.readFrom(this);
+       if(ugi == null) {
+         ugi = UserGroupInformation.login(this);
+       }
+       return ugi.getUserName();
     } catch (LoginException e) {
       throw (IOException)new IOException().initCause(e);
     }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java?rev=740941&r1=740940&r2=740941&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java Wed Feb  4 23:56:50 2009
@@ -553,6 +553,7 @@
       tbl.setProperty("last_modified_by", conf.getUser());
     } catch (IOException e) {
       console.printError("Unable to get current user: " + e.getMessage(), StringUtils.stringifyException(e));
+      return 1;
     }
     tbl.setProperty("last_modified_time", Long.toString(System
         .currentTimeMillis() / 1000));
@@ -722,8 +723,12 @@
       }
     }
 
-    // set owner, create_time etc
-    tbl.setOwner(System.getProperty("user.name"));
+    try {
+      tbl.setOwner(conf.getUser());
+    } catch (IOException e) {
+      console.printError("Unable to get current user: " + e.getMessage(), StringUtils.stringifyException(e));
+      return 1;
+    }
     // set create time
     tbl.getTTable().setCreateTime((int) (System.currentTimeMillis() / 1000));