You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2024/01/19 01:46:32 UTC

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20925


Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................

IMPALA-12711: Fix DDL errors are not shown in impalad logs

We use LOG_AND_RETURN_IF_ERROR to log the non-ok status of executing the
DDL. However, when enable_async_ddl_execution is true (default), the
returned status of ExecDdlRequest() and ExecLoadDataRequest() are about
creating the async thread. It's not the error of executing the
statement. If the DDL fails, no errors will be shown in impalad logs.

This patch fixes it by logging the error when UpdateQueryStatus() is
invoked by the async exec thread. A new parameter, 'log_error', is added
to this method to control the logging behavior. It's false by default
and only set to true when used in the async thread.

Tests
 - Add e2e test to verify the error in logs

Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
---
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M tests/metadata/test_ddl.py
3 files changed, 37 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/20925/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15015/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2024 05:13:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10183/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2024 07:45:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 18:41:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20925/3/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/20925/3/tests/metadata/test_ddl.py@1152
PS3, Line 1152: S
flake8: F821 undefined name 'SkipIfDockerizedCluster'



-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 23:32:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 18:40:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14998/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 02:14:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2024 04:49:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................

IMPALA-12711: Fix DDL errors are not shown in impalad logs

We use LOG_AND_RETURN_IF_ERROR to log the non-ok status of executing the
DDL. However, when enable_async_ddl_execution is true (default), the
returned status of ExecDdlRequest() and ExecLoadDataRequest() are about
creating the async thread. It's not the error of executing the
statement. If the DDL fails, no errors will be shown in impalad logs.

This patch fixes it by logging the error when UpdateQueryStatus() is
invoked by the async exec thread. A new parameter, 'log_error', is added
to this method to control the logging behavior. It's false by default
and only set to true when used in the async thread.

Tests
 - Add e2e test to verify the error in logs

Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Reviewed-on: http://gerrit.cloudera.org:8080/20925
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M tests/metadata/test_ddl.py
3 files changed, 39 insertions(+), 10 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15013/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 23:58:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20925/3/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/20925/3/tests/metadata/test_ddl.py@1152
PS3, Line 1152: S
> Need to import SkipIfDockerized
Oops, done



-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2024 04:46:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has removed a vote on this change.

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Removed Code-Review+2 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2024 12:19:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20925

to look at the new patch set (#3).

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................

IMPALA-12711: Fix DDL errors are not shown in impalad logs

We use LOG_AND_RETURN_IF_ERROR to log the non-ok status of executing the
DDL. However, when enable_async_ddl_execution is true (default), the
returned status of ExecDdlRequest() and ExecLoadDataRequest() are about
creating the async thread. It's not the error of executing the
statement. If the DDL fails, no errors will be shown in impalad logs.

This patch fixes it by logging the error when UpdateQueryStatus() is
invoked by the async exec thread. A new parameter, 'log_error', is added
to this method to control the logging behavior. It's false by default
and only set to true when used in the async thread.

Tests
 - Add e2e test to verify the error in logs

Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
---
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M tests/metadata/test_ddl.py
3 files changed, 38 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/20925/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20925

to look at the new patch set (#4).

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................

IMPALA-12711: Fix DDL errors are not shown in impalad logs

We use LOG_AND_RETURN_IF_ERROR to log the non-ok status of executing the
DDL. However, when enable_async_ddl_execution is true (default), the
returned status of ExecDdlRequest() and ExecLoadDataRequest() are about
creating the async thread. It's not the error of executing the
statement. If the DDL fails, no errors will be shown in impalad logs.

This patch fixes it by logging the error when UpdateQueryStatus() is
invoked by the async exec thread. A new parameter, 'log_error', is added
to this method to control the logging behavior. It's false by default
and only set to true when used in the async thread.

Tests
 - Add e2e test to verify the error in logs

Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
---
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M tests/metadata/test_ddl.py
3 files changed, 39 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/20925/4
-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10180/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 18:41:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10180/


-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 23:13:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12711: Fix DDL errors are not shown in impalad logs

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20925 )

Change subject: IMPALA-12711: Fix DDL errors are not shown in impalad logs
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20925/3/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/20925/3/tests/metadata/test_ddl.py@1152
PS3, Line 1152: S
> flake8: F821 undefined name 'SkipIfDockerizedCluster'
Need to import SkipIfDockerized



-- 
To view, visit http://gerrit.cloudera.org:8080/20925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f02f22fa8ebbd2dea722d5586899bf57b66cf40
Gerrit-Change-Number: 20925
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jan 2024 03:11:23 +0000
Gerrit-HasComments: Yes