[jira] Commented: (VELTOOLS-75) Add MessageTool.get method that accepts an explicit Locale

["Christopher Schultz (JIRA)" <de...@velocity.apache.org>]

    [ https://issues.apache.org/jira/browse/VELTOOLS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474896 ] 

Christopher Schultz commented on VELTOOLS-75:
---------------------------------------------

Apologies for the System.out.println still in there. I was trying to figure out why my get method wasn't being called (List version is called instead) and completely forgot after fixing it and verifying that it worked properly.

My diff was against the revision contained in the 1.3 release. I used that revision as the base since I want to use official releases (plus my own patches) in my own software. The revision number that the patch matched should have been present in the diff. Also, the original patch was against the same revision, and a newer revision was not available until after that first patch.

Given that patches will not always be applied immediately, what is the best policy for their base revisions? For instance, if the same patch had been submitted before 2007-02-15, would you have the same objection?


> Add MessageTool.get method that accepts an explicit Locale
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-75
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-75
>             Project: Velocity Tools
>          Issue Type: Improvement
>          Components: VelocityStruts
>            Reporter: Christopher Schultz
>            Priority: Trivial
>             Fix For: 1.4, 1.x, 2.0
>
>         Attachments: VELTOOLS-75.diff, VELTOOLS-75a.diff
>
>
> Perhaps this does not come up very often, but sometimes you want to display a message in a language that is not the current user's current locale.
> For instance, we are adding multi-language capability to our product, and I want to be able to display a list of languages for which the text "Switch to [language]" is displayed in the target language, not the user's current language (because if they can't read English, it's going to be hard for them to read "Switch to Your Language".
> I propose the addition of a getMessage method that allows you to explicitly indicate the locale to use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org