You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "meonkeys (via GitHub)" <gi...@apache.org> on 2025/01/17 18:44:56 UTC
[PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
meonkeys opened a new pull request, #4271:
URL: https://github.com/apache/fineract/pull/4271
## Description
https://issues.apache.org/jira/browse/FINERACT-2170
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made. **n/a**
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes **n/a**
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2613565410
@IOhacker no problem. Squashed and force-pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2622464602
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker merged PR #4271:
URL: https://github.com/apache/fineract/pull/4271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2599109290
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2600989193
I will review this as soon as I can, no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2613531842
@meonkeys squash and commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2611025895
I rebased to the tip of `develop` and resolved a conflict in `fineract-doc/build.gradle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2170: improve asciidoc: clean URIs, more [fineract]
Posted by "vorburger (via GitHub)" <gi...@apache.org>.
vorburger commented on PR #4271:
URL: https://github.com/apache/fineract/pull/4271#issuecomment-2600982964
@vidakovic this (asciidoc) was more your thing than mine, if memory serves me right? I'll leave this to you.
PS: Just FYI, I'm (meanwhile) a reasonably happy user of https://squidfunk.github.io/mkdocs-material/, based on https://www.mkdocs.org, for something that I'm toying with on https://docs.enola.dev personally. I've also set it up on https://google.github.io/android-fhir/. The Markdown (MD) syntax is nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org