You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "EMsnap (via GitHub)" <gi...@apache.org> on 2023/04/27 09:22:29 UTC

[GitHub] [inlong] EMsnap opened a new pull request, #7943: [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

EMsnap opened a new pull request, #7943:
URL: https://github.com/apache/inlong/pull/7943

   ### Prepare a Pull Request
   - Fixes #7840 
   
   ### Motivation
   
   [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector
   
   ### Modifications
   
   [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap merged pull request #7943: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #7943:
URL: https://github.com/apache/inlong/pull/7943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on a diff in pull request #7943: [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #7943:
URL: https://github.com/apache/inlong/pull/7943#discussion_r1186670073


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java:
##########
@@ -246,7 +246,9 @@ public static PulsarExtractNode createExtractNode(PulsarSource pulsarSource) {
                 serviceUrl,
                 format,
                 startupMode.getValue(),
-                primaryKey);
+                primaryKey,
+                "subName",
+                "earliest");

Review Comment:
   hard code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on a diff in pull request #7943: [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7943:
URL: https://github.com/apache/inlong/pull/7943#discussion_r1186967231


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java:
##########
@@ -246,7 +246,9 @@ public static PulsarExtractNode createExtractNode(PulsarSource pulsarSource) {
                 serviceUrl,
                 format,
                 startupMode.getValue(),
-                primaryKey);
+                primaryKey,
+                "subName",
+                "earliest");

Review Comment:
   wait for https://github.com/apache/inlong/pull/7937 to be merged first 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on pull request #7943: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7943:
URL: https://github.com/apache/inlong/pull/7943#issuecomment-1537694696

   @EMsnap This feature just can be used when pulsar admin api is supportted. Maybe, for without pulsar admin api situation, inlong manager can't distribute new params to support this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on pull request #7943: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #7943:
URL: https://github.com/apache/inlong/pull/7943#issuecomment-1537697741

   > @EMsnap This feature just can be used when pulsar admin api is supportted. Maybe, for without pulsar admin api situation, inlong manager can't distribute new params to support this feature.
   
   If there is no admin url the parameter won't be used since there is a seperate source for pulsar without admin
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on pull request #7943: [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #7943:
URL: https://github.com/apache/inlong/pull/7943#issuecomment-1537652941

   wait for https://github.com/apache/inlong/pull/7937 to be merged first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org