Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

["ahuang98 (via GitHub)" <gi...@apache.org>]

ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982108615


##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##########
@@ -795,21 +800,20 @@ public void testFetchSnapshotRequestAsLeader(boolean withKip853Rpc) throws Excep
     }
 
     @ParameterizedTest
-    @ValueSource(booleans = { false, true })
-    public void testLeaderShouldResignLeadershipIfNotGetFetchSnapshotRequestFromMajorityVoters(
-        boolean withKip853Rpc
-    ) throws Exception {
+    @EnumSource(value = RaftProtocol.class, names = {KIP_595_PROTOCOL, KIP_853_PROTOCOL})
+    public void testLeaderShouldResignLeadershipIfNotGetFetchSnapshotRequestFromMajorityVoters(RaftProtocol raftProtocol) throws Exception {
         int localId = randomReplicaId();
-        ReplicaKey voter1 = replicaKey(localId + 1, withKip853Rpc);
-        ReplicaKey voter2 = replicaKey(localId + 2, withKip853Rpc);
-        ReplicaKey observer3 = replicaKey(localId + 3, withKip853Rpc);
+        boolean support853 = isSupport853(raftProtocol);

Review Comment:
   was this change applied everywhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org