[GitHub] [airflow] mik-laj commented on a change in pull request #13906: Make webserver rolling update

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #13906:
URL: https://github.com/apache/airflow/pull/13906#discussion_r566608579



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -39,7 +39,7 @@ spec:
   strategy:
     type: RollingUpdate
     rollingUpdate:
-      maxUnavailable: 1
+      maxUnavailable: 0

Review comment:
       It makes sense for me to provide support for service updates by default, with a guarantee of its continuous availability. I don't think HA for the webserver is often deployed because the webserver is not used very heavily because the key feature are provided by the webserver and worker. The web server only supports the use of Airflow but is an optional component. The Web Server only supports the use of Airflow, but from a design perspective it is an optional, non-essential component, so in most cases, HA is not necessary.
   
   However, to handle both cases, we can add a condition. If `replicas > 2`, then the `maxUnavailable = replicas - 1,` If `replicas == 1`, then `maxUnavailable = 0`. What do you think about it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org