[GitHub] [iceberg] rdblue commented on a diff in pull request #5467: Python: Add support for hierarchical namespaces

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5467:
URL: https://github.com/apache/iceberg/pull/5467#discussion_r942673435


##########
python/tests/catalog/test_rest.py:
##########
@@ -139,7 +139,7 @@ def test_list_tables_404(rest_mock: Mocker):
 
 def test_list_namespaces_200(rest_mock: Mocker):
     rest_mock.get(
-        f"{TEST_URI}v1/namespaces",
+        f"{TEST_URI}v1/namespaces?parent=",

Review Comment:
   I think that we should omit parent if there is no parent. Including it makes it unclear whether this is asking for the root or a parent named `""`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org