You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2023/01/11 23:41:20 UTC
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19415
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
IMPALA-11836: Remove duplicated information in codegen cache logs
The patch removes duplicated logs when a codegen cache is stored
and also removes the query id from the codegen cache logs because
the information is already included in the log.
Tests:
Passed core tests.
Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
2 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/19415/1
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12151/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:27:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19415/1/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:
http://gerrit.cloudera.org:8080/#/c/19415/1/be/src/codegen/llvm-codegen.cc@2005
PS1, Line 2005:
> This newline only needed if debug_mode is True? Maybe move it to the branch
Thanks, seems the LOG can remove the redundant newline, but agree that it is good to put it in the debug branch. Done.
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:09:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:14:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12150/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 00:02:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8970/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Jan 2023 01:01:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Jan 2023 14:02:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 1:
(1 comment)
Thanks Yida! Just have one comment.
http://gerrit.cloudera.org:8080/#/c/19415/1/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:
http://gerrit.cloudera.org:8080/#/c/19415/1/be/src/codegen/llvm-codegen.cc@2005
PS1, Line 2005: << "\n"
This newline only needed if debug_mode is True? Maybe move it to the branch below?
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 00:35:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19415/2/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:
http://gerrit.cloudera.org:8080/#/c/19415/2/be/src/codegen/llvm-codegen.cc@2007
PS2, Line 2007: out << "\nFragment Plan: " << apache::thrift::ThriftDebugString(state_->fragment())
Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead.
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:08:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Jan 2023 06:06:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
IMPALA-11836: Remove duplicated information in codegen cache logs
The patch removes duplicated logs when a codegen cache is stored
and also removes the query id from the codegen cache logs because
the information is already included in the log.
Tests:
Passed core tests.
Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Reviewed-on: http://gerrit.cloudera.org:8080/19415
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
2 files changed, 7 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Jan 2023 01:01:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
Patch Set 2: Code-Review+2
Thanks Yida! Carrying +2.
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Jan 2023 16:34:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19415 )
Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs
......................................................................
IMPALA-11836: Remove duplicated information in codegen cache logs
The patch removes duplicated logs when a codegen cache is stored
and also removes the query id from the codegen cache logs because
the information is already included in the log.
Tests:
Passed core tests.
Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
2 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/19415/2
--
To view, visit http://gerrit.cloudera.org:8080/19415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a19ea4394c651d1cf64fce92375e7fa5cb09baa
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>