You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/04 11:31:30 UTC
[GitHub] [camel] bvahdat opened a new pull request, #8830: Upgrade opentelemetry to the version 1.20.1
bvahdat opened a new pull request, #8830:
URL: https://github.com/apache/camel/pull/8830
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
- Will separately look into `camel-opentelemetry-starter` and provide PR by it's related repo if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336393860
I have only removed the `public` modifiers in Tests, please see Sam Brannen's answer here:
https://stackoverflow.com/a/55230350
Who is the main contributor to JUnit 5:
https://github.com/junit-team/junit5/graphs/contributors
And I think @essobedo also applies the same pattern by all his PRs which makes sense to me as well.
Also please see the INFO box here:
https://junit.org/junit5/docs/current/user-guide/#writing-tests-classes-and-methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1337113528
> > I am not sure why the CI server failed the 2nd time
>
> These are test failures in core not relevant to this PR. Though not sure why those tests are run in the first place, as this PR has no effect on e.g. `camel-core`, but maybe @orpiske knows more about it.
One of the core tests is flaky on Github actions. Let's see if #8835 improves a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336388006
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336477079
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336389863
Why do you remove the public in all that source code ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1340833037
> > We should not change public in test methods which causes backport problems as the code is changed compared to older branches.
>
> IMHO, that's a cleanup we need to do separately and in one shot per component (so we can cherry-pick) and only removing the `public` modifier. Maybe for Camel 4 ...
Thanks @orpiske for your feedback. This has been now taken care of separately through https://github.com/apache/camel/pull/8831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336416180
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336414626
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 0 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336480553
> I am not sure why the CI server failed the 2nd time
These are test failures in core not relevant to this PR. Though not sure why those tests are run in the first place, as this PR has no effect on e.g. `camel-core`, but maybe @orpiske knows more about it.
Anyway going to rebase & merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336398791
Please keep as before, this PR is about dependency upgrade.
We should not change `public` in test methods which causes backport problems as the code is changed compared to older branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336398868
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1337115772
> We should not change public in test methods which causes backport problems as the code is changed compared to older branches.
IMHO, that's a cleanup we need to do separately and in one shot per component (so we can cherry-pick) and only removing the `public` modifier. Maybe for Camel 4 ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336403467
> Please keep as before, this PR is about dependency upgrade.
>
> We should not change `public` in test methods which causes backport problems as the code is changed compared to older branches.
Sure, is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8830:
URL: https://github.com/apache/camel/pull/8830#issuecomment-1336449139
I am not sure why the CI server failed the 2nd time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat merged pull request #8830: Upgrade opentelemetry to the version 1.20.1
Posted by GitBox <gi...@apache.org>.
bvahdat merged PR #8830:
URL: https://github.com/apache/camel/pull/8830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org