You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/28 10:43:28 UTC

[GitHub] [airflow] potiuk commented on issue #6929: [AIRFLOW-6373] Make airflow/utils pylint compatible

potiuk commented on issue #6929: [AIRFLOW-6373] Make airflow/utils pylint compatible
URL: https://github.com/apache/airflow/pull/6929#issuecomment-569405772
 
 
   The reasons are .... cyclic imports :)
   
   The problem is that sometimes we have too many grouped classes in one module where it is really not supposed to be groupped. For example the baseoperator->helpers cyclic import is caused by "chain" method in helpers. BaseOperator uses helpers module and helpers.chain() method uses BaseOperator. This all can be resolved by careful untangling of modules. Sometimes what helps is putting together things that are actually coupled by historically are in separate modules. I have some experience with that and will try to add a few commits on top of yours to solve it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services