[GitHub] [lucene] gsmiller commented on issue #12276: Maybe rename `DaciukMihovAutomatonBuilder`?

["gsmiller (via GitHub)" <gi...@apache.org>]

gsmiller commented on issue #12276:
URL: https://github.com/apache/lucene/issues/12276#issuecomment-1546298721

   +1 to `StringsToAutomaton` language. I'd suggest keeping "Builder" in the name.
   
   In general, also +1 to renaming. The algorithm doesn't have to only be applied to strings (e.g., it could directly be applied to binary data, as long as it's sorted). So having something that references "string" in the name feels right to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org