Re: svn commit: r608435 - in /myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html: HtmlFormRendererBase.java HtmlLinkRendererBase.java

[Simon Kitching <si...@chello.at>]

---- imario@apache.org schrieb:
> Author: imario
> Date: Thu Jan  3 02:49:04 2008
> New Revision: 608435
> 
> URL: http://svn.apache.org/viewvc?rev=608435&view=rev
> Log:
> MYFACES-1753: removed writing of unused jsf_sequence hidden field/parameter
> 
> Modified:
>     myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlFormRendererBase.java
>     myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
> 
> Modified: myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlFormRendererBase.java
> URL: http://svn.apache.org/viewvc/myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlFormRendererBase.java?rev=608435&r1=608434&r2=608435&view=diff
> ==============================================================================
> --- myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlFormRendererBase.java (original)
> +++ myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlFormRendererBase.java Thu Jan  3 02:49:04 2008
> @@ -6,9 +6,9 @@
> +		/* this one is encoded into the ViewState hidden 
...
> +        */


I would prefer to see useless code removed rather than just commented out. It's really hard to see what effect a patch has when the diff file just shows a start comment and end-comment line added.

And if we always just comment old code out, then files will get pretty ugly.

If code does need to be put back in, or people want to see what was removed when, then svn has that info..

Regards,

Simon