You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/14 21:11:11 UTC
[kudu-CR] [docker] Update the supported base images
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16877
Change subject: [docker] Update the supported base images
......................................................................
[docker] Update the supported base images
This patch updates the base images available to chose from in
docker-build.py to match those listed on the installation documentation.
Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
---
M docker/docker-build.py
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/16877/1
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Update the supported base images
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py@67
PS3, Line 67: bionic
> So far we have been using the oldest available release as the default. I ha
I'm not sure that's true -- in the prior version of this file, the DEFAULT_OS was set to 'ubuntu:xenial', but the list of available releases for Ubuntu was 'ubuntu:trusty', 'ubuntu:xenial', 'ubuntu:bionic' and the oldest one among those was 'ubuntu:trusty, not 'ubuntu:xenial'.
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Jan 2021 16:11:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update the supported base images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py@67
PS3, Line 67: bionic
> I'm not sure that's true -- in the prior version of this file, the DEFAULT_
ah, true. I suppose it may have been more arbitrary. I am happy to update it to be focal if you think that's a better choice.
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Jan 2021 16:30:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update the supported base images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16877
to look at the new patch set (#3).
Change subject: [docker] Update the supported base images
......................................................................
[docker] Update the supported base images
This patch updates the base images available to chose from in
docker-build.py to match those listed on the installation documentation.
Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
---
M docker/docker-build.py
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/16877/3
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Update the supported base images
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py@67
PS3, Line 67: bionic
> ah, true. I suppose it may have been more arbitrary. I am happy to update i
I think current choice of bionic is good as of now. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Feb 2021 18:55:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update the supported base images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16877
to look at the new patch set (#2).
Change subject: [docker] Update the supported base images
......................................................................
[docker] Update the supported base images
This patch updates the base images available to chose from in
docker-build.py to match those listed on the installation documentation.
Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
---
M docker/docker-build.py
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/16877/2
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Update the supported base images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py@67
PS3, Line 67: bionic
> nit: I'm curious what's the criterion to use particular release out of avai
So far we have been using the oldest available release as the default. I haven't really thought much about the choice. We can change it if you think we should in the future.
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Jan 2021 15:02:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update the supported base images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
[docker] Update the supported base images
This patch updates the base images available to chose from in
docker-build.py to match those listed on the installation documentation.
Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Reviewed-on: http://gerrit.cloudera.org:8080/16877
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docker/docker-build.py
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Update the supported base images
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jan 2021 14:31:24 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Update the supported base images
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16877 )
Change subject: [docker] Update the supported base images
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16877/3/docker/docker-build.py@67
PS3, Line 67: bionic
nit: I'm curious what's the criterion to use particular release out of available ones (e.g., why not switch to 'focal' at this point already?)
--
To view, visit http://gerrit.cloudera.org:8080/16877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b90f77f803a503f63f616a61080dcde4ee35a5
Gerrit-Change-Number: 16877
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Jan 2021 22:46:19 +0000
Gerrit-HasComments: Yes