You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 22:34:33 UTC

[GitHub] [airflow] hankehly commented on a diff in pull request #27564: CloudWatch task handler doesn't fall back to local logs when Amazon CloudWatch logs aren't found

hankehly commented on code in PR #27564:
URL: https://github.com/apache/airflow/pull/27564#discussion_r1018477719


##########
tests/providers/amazon/aws/log/test_cloudwatch_task_handler.py:
##########
@@ -154,49 +154,22 @@ def test_read(self):
             [{"end_of_log": True}],
         )
 
-    def test_read_wrong_log_stream(self):

Review Comment:
   I deleted these 2 test cases for the following reasons.
   * They overlap with the one I added (testing for generic failure to fetch remote logs)
   * AWS error messages are now propagated to the task log. These strings could change in the future and break our unit tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org