You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/20 07:54:21 UTC
[GitHub] [hive] klcopp commented on a change in pull request #2277: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state
klcopp commented on a change in pull request #2277:
URL: https://github.com/apache/hive/pull/2277#discussion_r672892362
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -282,15 +282,12 @@ private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci, Tab
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
ValidReaderWriteIdList validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
- boolean delayedCleanupEnabled = conf.getBoolVar(HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED);
- if (delayedCleanupEnabled) {
- /*
- * If delayed cleanup enabled, we need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
- * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
- * should not touch the newer obsolete directories to not to violate the retentionTime for those.
- */
- validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
- }
+ /*
+ * We need to filter the obsoletes dir list, to only remove directories that were made obsolete by this compaction
+ * If we have a higher retentionTime it is possible for a second compaction to run on the same partition. Cleaning up the first compaction
+ * should not touch the newer obsolete directories to not to violate the retentionTime for those.
+ */
+ validWriteIdList = validWriteIdList.updateHighWatermark(ci.highestWriteId);
Review comment:
How do we know that ci.highestWriteId's txn <= the min open txn the cleaner uses, if MIN_HISTORY_LEVEL is still used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org