You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/21 08:54:14 UTC
[GitHub] [spark] MaxGekk opened a new pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
MaxGekk opened a new pull request #34969:
URL: https://github.com/apache/spark/pull/34969
### What changes were proposed in this pull request?
Change a wrong example in the SQL migration guide, and align it to the description of behavior change.
### Why are the changes needed?
Current example is incorrect, and can confuse users.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the example:
```sql
spark-sql> select INTERVAL 1 day 1 hour;
1 01:00:00.000000000
spark-sql> select INTERVAL 1 month 1 hour;
Error in query:
Cannot mix year-month and day-time fields: INTERVAL 1 month 1 hour(line 1, pos 7)
== SQL ==
select INTERVAL 1 month 1 hour
-------^^^
spark-sql> set spark.sql.legacy.interval.enabled=true;
spark.sql.legacy.interval.enabled true
spark-sql> select INTERVAL 1 month 1 hour;
1 months 1 hours
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998597531
FYI, this should be merged to branch-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998589151
**[Test build #146430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146430/testReport)** for PR 34969 at commit [`0f85fb6`](https://github.com/apache/spark/commit/0f85fb68bb36551abb2657a52bebf5cdb7f37390).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998682496
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998603525
**[Test build #146430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146430/testReport)** for PR 34969 at commit [`0f85fb6`](https://github.com/apache/spark/commit/0f85fb68bb36551abb2657a52bebf5cdb7f37390).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34969:
URL: https://github.com/apache/spark/pull/34969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998589151
**[Test build #146430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146430/testReport)** for PR 34969 at commit [`0f85fb6`](https://github.com/apache/spark/commit/0f85fb68bb36551abb2657a52bebf5cdb7f37390).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998629121
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998625645
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146430/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998682468
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998625645
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146430/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998645149
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34969: [SPARK-37692][DOCS] Fix an example of mixed interval fields in the SQL migration guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34969:
URL: https://github.com/apache/spark/pull/34969#issuecomment-998682496
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50906/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org